List for cgit developers and users
 help / color / mirror / Atom feed
From: Christian Hesse <list@eworm.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: cgit@lists.zx2c4.com, Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] RFC: git: update to v2.41.0-rc2
Date: Fri, 26 May 2023 16:17:35 +0200	[thread overview]
Message-ID: <20230526161735.57ebdc54@leda.eworm.net> (raw)
In-Reply-To: <20230526160653.7962c827@leda.eworm.net>

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Christian Hesse <list@eworm.de> on Fri, 2023/05/26 16:06:
> > Like string_list_split(), except that string is split in-place: the
> > delimiter characters in string are overwritten with NULs, and the
> > new string_list_items point into string (which therefore must not
> > be modified or freed while the string_list is in use).
> > list->strdup_strings must *not* be set.  
> 
> So we should be fine with the change, no?

Ah, the strings are not allocated, but we should run:

string_list_clear(&list, 0);

Is it fine then?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-05-26 14:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 11:06 Christian Hesse
2023-05-26 13:42 ` Jason A. Donenfeld
2023-05-26 14:06   ` Christian Hesse
2023-05-26 14:17     ` Christian Hesse [this message]
2023-05-26 14:18       ` Jason A. Donenfeld
2023-05-26 14:21         ` Christian Hesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526161735.57ebdc54@leda.eworm.net \
    --to=list@eworm.de \
    --cc=Jason@zx2c4.com \
    --cc=cgit@lists.zx2c4.com \
    --cc=mail@eworm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).