List for cgit developers and users
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Christian Hesse <list@eworm.de>
Cc: cgit@lists.zx2c4.com, Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] RFC: git: update to v2.41.0-rc2
Date: Fri, 26 May 2023 16:18:42 +0200	[thread overview]
Message-ID: <CAHmME9r=XAoO-yYbnxrRQM=b-RhXYJ2dwy06quWPniG=m2Kkqw@mail.gmail.com> (raw)
In-Reply-To: <20230526161735.57ebdc54@leda.eworm.net>

On Fri, May 26, 2023 at 4:17 PM Christian Hesse <list@eworm.de> wrote:
>
> Christian Hesse <list@eworm.de> on Fri, 2023/05/26 16:06:
> > > Like string_list_split(), except that string is split in-place: the
> > > delimiter characters in string are overwritten with NULs, and the
> > > new string_list_items point into string (which therefore must not
> > > be modified or freed while the string_list is in use).
> > > list->strdup_strings must *not* be set.
> >
> > So we should be fine with the change, no?
>
> Ah, the strings are not allocated, but we should run:
>
> string_list_clear(&list, 0);
>
> Is it fine then?

Right. My understanding is that while the strings themselves are not
allocated, the array of string list items still is.

  reply	other threads:[~2023-05-26 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 11:06 Christian Hesse
2023-05-26 13:42 ` Jason A. Donenfeld
2023-05-26 14:06   ` Christian Hesse
2023-05-26 14:17     ` Christian Hesse
2023-05-26 14:18       ` Jason A. Donenfeld [this message]
2023-05-26 14:21         ` Christian Hesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9r=XAoO-yYbnxrRQM=b-RhXYJ2dwy06quWPniG=m2Kkqw@mail.gmail.com' \
    --to=jason@zx2c4.com \
    --cc=cgit@lists.zx2c4.com \
    --cc=list@eworm.de \
    --cc=mail@eworm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).