From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 09/13] ui-stats: make cgit_period definitions 'static const'
Date: Sun, 8 Mar 2015 16:32:23 +0000 [thread overview]
Message-ID: <480f57e7c083dfb0bbeb1a8dc8ad415021422c0a.1425832129.git.john@keeping.me.uk> (raw)
In-Reply-To: <cover.1425832128.git.john@keeping.me.uk>
These definitions should not be modified (and never are) so we can move
them to .rodata.
Signed-off-by: John Keeping <john at keeping.me.uk>
---
ui-stats.c | 14 +++++++-------
ui-stats.h | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/ui-stats.c b/ui-stats.c
index a264f6a..9cd8247 100644
--- a/ui-stats.c
+++ b/ui-stats.c
@@ -125,7 +125,7 @@ static char *pretty_year(struct tm *tm)
return fmt("%d", tm->tm_year + 1900);
}
-struct cgit_period periods[] = {
+static const struct cgit_period periods[] = {
{'w', "week", 12, 4, trunc_week, dec_week, inc_week, pretty_week},
{'m', "month", 12, 4, trunc_month, dec_month, inc_month, pretty_month},
{'q', "quarter", 12, 4, trunc_quarter, dec_quarter, inc_quarter, pretty_quarter},
@@ -136,7 +136,7 @@ struct cgit_period periods[] = {
* and update the period pointer to the correcsponding struct.
* If no matching code is found, return 0.
*/
-int cgit_find_stats_period(const char *expr, struct cgit_period **period)
+int cgit_find_stats_period(const char *expr, const struct cgit_period **period)
{
int i;
char code = '\0';
@@ -165,7 +165,7 @@ const char *cgit_find_stats_periodname(int idx)
}
static void add_commit(struct string_list *authors, struct commit *commit,
- struct cgit_period *period)
+ const struct cgit_period *period)
{
struct commitinfo *info;
struct string_list_item *author, *item;
@@ -209,7 +209,7 @@ static int cmp_total_commits(const void *a1, const void *a2)
/* Walk the commit DAG and collect number of commits per author per
* timeperiod into a nested string_list collection.
*/
-static struct string_list collect_stats(struct cgit_period *period)
+static struct string_list collect_stats(const struct cgit_period *period)
{
struct string_list authors;
struct rev_info rev;
@@ -256,7 +256,7 @@ static void print_combined_authorrow(struct string_list *authors, int from,
const char *leftclass,
const char *centerclass,
const char *rightclass,
- struct cgit_period *period)
+ const struct cgit_period *period)
{
struct string_list_item *author;
struct authorstat *authorstat;
@@ -295,7 +295,7 @@ static void print_combined_authorrow(struct string_list *authors, int from,
}
static void print_authors(struct string_list *authors, int top,
- struct cgit_period *period)
+ const struct cgit_period *period)
{
struct string_list_item *author;
struct authorstat *authorstat;
@@ -363,7 +363,7 @@ static void print_authors(struct string_list *authors, int top,
void cgit_show_stats(void)
{
struct string_list authors;
- struct cgit_period *period;
+ const struct cgit_period *period;
int top, i;
const char *code = "w";
diff --git a/ui-stats.h b/ui-stats.h
index 341ab13..0e61b03 100644
--- a/ui-stats.h
+++ b/ui-stats.h
@@ -20,7 +20,7 @@ struct cgit_period {
char *(*pretty)(struct tm *tm);
};
-extern int cgit_find_stats_period(const char *expr, struct cgit_period **period);
+extern int cgit_find_stats_period(const char *expr, const struct cgit_period **period);
extern const char *cgit_find_stats_periodname(int idx);
extern void cgit_show_stats(void);
--
2.3.1.308.g754cd77
next prev parent reply other threads:[~2015-03-08 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 16:32 [PATCH 00/13] Fixes for problems detected by Sparse john
2015-03-08 16:32 ` [PATCH 01/13] Makefile: add a target to run CGit through sparse john
2015-03-08 16:32 ` [PATCH 02/13] Avoid non-ANSI function declarations john
2015-03-08 16:32 ` [PATCH 03/13] Avoid signed bitfields john
2015-03-08 16:32 ` [PATCH 04/13] scan-tree: make some variables 'static' john
2015-03-08 16:32 ` [PATCH 05/13] shared: " john
2015-03-08 16:32 ` [PATCH 06/13] ui-log: " john
2015-03-08 16:32 ` [PATCH 07/13] ui-repolist: make sortcolumn definitions 'static const' john
2015-03-08 16:32 ` [PATCH 08/13] ui-shared: make cgit_doctype 'static' john
2015-03-08 16:32 ` john [this message]
2015-03-08 16:32 ` [PATCH 10/13] ui-shared: avoid initializing static variable to zero john
2015-03-08 16:32 ` [PATCH 11/13] ui-shared: don't use an integer as a NULL pointer john
2015-03-08 16:32 ` [PATCH 12/13] cache: " john
2015-03-08 16:32 ` [PATCH 13/13] html: avoid using a plain " john
2015-03-09 16:41 ` [PATCH 00/13] Fixes for problems detected by Sparse Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480f57e7c083dfb0bbeb1a8dc8ad415021422c0a.1425832129.git.john@keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).