From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 03/13] Avoid signed bitfields
Date: Sun, 8 Mar 2015 16:32:17 +0000 [thread overview]
Message-ID: <fa962c1e536eefcec18d1ed9d6bbbf86a412ead8.1425832129.git.john@keeping.me.uk> (raw)
In-Reply-To: <cover.1425832128.git.john@keeping.me.uk>
Bitfields are only defined for unsigned types.
Detected by sparse.
Signed-off-by: John Keeping <john at keeping.me.uk>
---
ui-blob.c | 4 ++--
ui-diff.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ui-blob.c b/ui-blob.c
index a025bca..388a017 100644
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -14,8 +14,8 @@
struct walk_tree_context {
const char *match_path;
unsigned char *matched_sha1;
- int found_path:1;
- int file_only:1;
+ unsigned int found_path:1;
+ unsigned int file_only:1;
};
static int walk_tree(const unsigned char *sha1, struct strbuf *base,
diff --git a/ui-diff.c b/ui-diff.c
index 8eff178..1cf2ce0 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -31,7 +31,7 @@ static struct fileinfo {
unsigned int removed;
unsigned long old_size;
unsigned long new_size;
- int binary:1;
+ unsigned int binary:1;
} *items;
static int use_ssdiff = 0;
--
2.3.1.308.g754cd77
next prev parent reply other threads:[~2015-03-08 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 16:32 [PATCH 00/13] Fixes for problems detected by Sparse john
2015-03-08 16:32 ` [PATCH 01/13] Makefile: add a target to run CGit through sparse john
2015-03-08 16:32 ` [PATCH 02/13] Avoid non-ANSI function declarations john
2015-03-08 16:32 ` john [this message]
2015-03-08 16:32 ` [PATCH 04/13] scan-tree: make some variables 'static' john
2015-03-08 16:32 ` [PATCH 05/13] shared: " john
2015-03-08 16:32 ` [PATCH 06/13] ui-log: " john
2015-03-08 16:32 ` [PATCH 07/13] ui-repolist: make sortcolumn definitions 'static const' john
2015-03-08 16:32 ` [PATCH 08/13] ui-shared: make cgit_doctype 'static' john
2015-03-08 16:32 ` [PATCH 09/13] ui-stats: make cgit_period definitions 'static const' john
2015-03-08 16:32 ` [PATCH 10/13] ui-shared: avoid initializing static variable to zero john
2015-03-08 16:32 ` [PATCH 11/13] ui-shared: don't use an integer as a NULL pointer john
2015-03-08 16:32 ` [PATCH 12/13] cache: " john
2015-03-08 16:32 ` [PATCH 13/13] html: avoid using a plain " john
2015-03-09 16:41 ` [PATCH 00/13] Fixes for problems detected by Sparse Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa962c1e536eefcec18d1ed9d6bbbf86a412ead8.1425832129.git.john@keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).