List for cgit developers and users
 help / color / mirror / Atom feed
Subject: [PATCH v2 2/2] log: allow users to follow a file
Date: Sat, 20 Apr 2013 13:21:52 +0200	[thread overview]
Message-ID: <51727A50.3070401@necoro.eu> (raw)
In-Reply-To: <63567740b5b2b2b79eafff7a00148ef8a7b71bad.1366452850.git.john@keeping.me.uk>

Awesome! Your patches work great over here. I'm so glad, I had not tried
to implement this myself :)

> For commits before the file has been renamed (i.e. that appear later in
> the log list) we change the file path in the links from the log to point
> to the old name; this means that links to commits always limit by the
> path known to that commit.  If we didn't do this we would need to walk
> down the log diff'ing every commit whenever we want to show a commit.
> The drawback is that the "Log" link in the top bar of such a page links
> to the log limited by the old name, so it will only show pre-rename
> commits.  I consider this a reasonable trade-off since the "Back" button
> still works and the log matches the path displayed in the top bar.

I also think this is reasonable. When running into this issue, you
usually already know what you are doing, so one might be surprised but
not lost.

- Ren?




  reply	other threads:[~2013-04-20 11:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 11:51 log --follow 
2013-04-15 12:38 ` john
2013-04-15 17:30   ` 
2013-04-16  8:48     ` john
2013-04-17 19:48       ` [PATCH] log: allow users to follow a file john
2013-04-18 17:31         ` 
2013-04-19  7:54           ` john
2013-04-20 10:14             ` [PATCH v2 0/2] Allow users to follow file renames john
2013-04-20 10:14               ` [PATCH v2 1/2] shared: make cgit_diff_tree_cb public john
2013-04-20 10:14               ` [PATCH v2 2/2] log: allow users to follow a file john
2013-04-20 11:21                 `  [this message]
2013-04-20 12:21                 ` [PATCH 2/2 v3] " john
2015-03-24  6:02                   ` 
2015-08-12 14:34                   ` [PATCH v4 1/2] shared: make cgit_diff_tree_cb public john
2015-08-12 14:55                     ` [PATCH v4 2/2] log: allow users to follow a file john
2015-08-12 15:01                       ` Jason
2015-08-12 15:41                     ` [PATCH v4 1/2] shared: make cgit_diff_tree_cb public Jason
2013-04-26 13:52               ` [PATCH v2 0/2] Allow users to follow file renames Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51727A50.3070401@necoro.eu \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).