Fwd: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

Fwd: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[mailings]

-------- Forwarded Message --------
Subject: 	Build failed in Jenkins: cgit - upstream - get-git - master 
#190 - remotes/origin/master - a360666
Date: 	Thu, 13 Aug 2015 15:43:11 +0200 (CEST)
From: 	Pelagic Jenkins (Public) <noreply at jenkins-public.pelagic.nl>
To: 	ferry.huberts at pelagic.nl



See <https://hupie.dyndns.org:15051/jenkins/job/cgit%20-%20upstream%20-%20get-git%20-%20master/190/changes>

Changes:

[Jason at zx2c4.com] tests: allow shell to be overridden

[Jason at zx2c4.com] Makefile: include Git's config.mak.uname

[Jason at zx2c4.com] Remove redundant includes

[Jason at zx2c4.com] configfile.c: don't include system headers directly

[Jason at zx2c4.com] cache.c: fix header order

[Jason at zx2c4.com] cgit.h: move stdbool.h from ui-shared.h

[Jason at zx2c4.com] ui-tree: use "sane" isgraph()

[Jason at zx2c4.com] filter: don't use dlsym unnecessarily

[Jason at zx2c4.com] ui-shared: extract date formatting to a function

[Jason at zx2c4.com] ui-shared: use common function in print_rel_date()

[Jason at zx2c4.com] ui-shared: show full date in tooltip if longer ago than max_relative

------------------------------------------
Started by an SCM change
Building in workspace <https://hupie.dyndns.org:15051/jenkins/job/cgit%20-%20upstream%20-%20get-git%20-%20master/ws/>
  > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  > git config remote.origin.url http://git.zx2c4.com/cgit # timeout=10
Pruning obsolete local branches
Fetching upstream changes from http://git.zx2c4.com/cgit
  > git --version # timeout=10
  > git -c core.askpass=true fetch --tags --progress http://git.zx2c4.com/cgit +refs/heads/*:refs/remotes/origin/* --prune
  > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
  > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision a360666df3cfcd1b384cd66b18803d72e3893b3d (refs/remotes/origin/master)
  > git config core.sparsecheckout # timeout=10
  > git checkout -f a360666df3cfcd1b384cd66b18803d72e3893b3d
  > git rev-list c0b59823035efc136a82a96094d164a979d9b2e9 # timeout=10
Cleaning workspace
  > git rev-parse --verify HEAD # timeout=10
Resetting working tree
  > git reset --hard # timeout=10
  > git clean -fdx # timeout=10
[cgit_upstream_get-git_master] $ /bin/bash /tmp/hudson885616167373264074.sh
Makefile:36: git/config.mak.uname: No such file or directory
make: *** No rule to make target 'git/config.mak.uname'.  Stop.
Build step 'Execute shell' marked build as failure
Archiving artifacts



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20150813/eaf26007/attachment-0001.html>

Fwd: Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[mailings]

Maybe you guys can check my build server after merging commits? :-)

It runs Fedora 22, x86_64

On 13/08/15 16:28, Ferry Huberts wrote:
>
>
>
> -------- Forwarded Message --------
> Subject: 	Build failed in Jenkins: cgit - upstream - get-git - master
> #190 - remotes/origin/master - a360666
> Date: 	Thu, 13 Aug 2015 15:43:11 +0200 (CEST)
> From: 	Pelagic Jenkins (Public) <noreply at jenkins-public.pelagic.nl>
> To: 	ferry.huberts at pelagic.nl
>
>
>
> See<https://hupie.dyndns.org:15051/jenkins/job/cgit%20-%20upstream%20-%20get-git%20-%20master/190/changes>
>
> Changes:
>
> [Jason at zx2c4.com] tests: allow shell to be overridden
>
> [Jason at zx2c4.com] Makefile: include Git's config.mak.uname
>
> [Jason at zx2c4.com] Remove redundant includes
>
> [Jason at zx2c4.com] configfile.c: don't include system headers directly
>
> [Jason at zx2c4.com] cache.c: fix header order
>
> [Jason at zx2c4.com] cgit.h: move stdbool.h from ui-shared.h
>
> [Jason at zx2c4.com] ui-tree: use "sane" isgraph()
>
> [Jason at zx2c4.com] filter: don't use dlsym unnecessarily
>
> [Jason at zx2c4.com] ui-shared: extract date formatting to a function
>
> [Jason at zx2c4.com] ui-shared: use common function in print_rel_date()
>
> [Jason at zx2c4.com] ui-shared: show full date in tooltip if longer ago than max_relative
>
> ------------------------------------------
> Started by an SCM change
> Building in workspace<https://hupie.dyndns.org:15051/jenkins/job/cgit%20-%20upstream%20-%20get-git%20-%20master/ws/>
>   > git rev-parse --is-inside-work-tree # timeout=10
> Fetching changes from the remote Git repository
>   > git config remote.origin.urlhttp://git.zx2c4.com/cgit  # timeout=10
> Pruning obsolete local branches
> Fetching upstream changes fromhttp://git.zx2c4.com/cgit
>   > git --version # timeout=10
>   > git -c core.askpass=true fetch --tags --progresshttp://git.zx2c4.com/cgit  +refs/heads/*:refs/remotes/origin/* --prune
>   > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
>   > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
> Checking out Revision a360666df3cfcd1b384cd66b18803d72e3893b3d (refs/remotes/origin/master)
>   > git config core.sparsecheckout # timeout=10
>   > git checkout -f a360666df3cfcd1b384cd66b18803d72e3893b3d
>   > git rev-list c0b59823035efc136a82a96094d164a979d9b2e9 # timeout=10
> Cleaning workspace
>   > git rev-parse --verify HEAD # timeout=10
> Resetting working tree
>   > git reset --hard # timeout=10
>   > git clean -fdx # timeout=10
> [cgit_upstream_get-git_master] $ /bin/bash /tmp/hudson885616167373264074.sh
> Makefile:36: git/config.mak.uname: No such file or directory
> make: *** No rule to make target 'git/config.mak.uname'.  Stop.
> Build step 'Execute shell' marked build as failure
> Archiving artifacts
>
>
>
>
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
>

-- 
Ferry Huberts

Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[Jason]

John -- why are their circumstances in which your config.mak.uname isn't
created?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20150813/ca290306/attachment.html>

Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[mailings]

On 13/08/15 16:32, Jason A. Donenfeld wrote:
> John -- why are their circumstances in which your config.mak.uname isn't
> created?

It's in the 'get-git' build.
So that is the build in which git is built from a 'release' tar instead 
of from its repo


-- 
Ferry Huberts

Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[john]

On Thu, Aug 13, 2015 at 04:35:51PM +0200, Ferry Huberts wrote:
> 
> 
> On 13/08/15 16:32, Jason A. Donenfeld wrote:
> > John -- why are their circumstances in which your config.mak.uname isn't
> > created?
> 
> It's in the 'get-git' build.
> So that is the build in which git is built from a 'release' tar instead 
> of from its repo

And the problem is in the "get-git" stage, at which point the "git"
directory doesn't exist.

This fixes it:

-- >8 --
Subject: [PATCH] Makefile: make "git/config.mak.uname" inclusion optional

If we haven't got a "git" directory, it should still be possible to run
"make get-git", so we cannot include this file unconditionally.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 74061a3..a0a6615 100644
--- a/Makefile
+++ b/Makefile
@@ -33,7 +33,7 @@ DOC_PDF  = $(patsubst %.txt,%.pdf,$(MAN_TXT))
 
 #-include config.mak
 
-include git/config.mak.uname
+-include git/config.mak.uname
 #
 # Let the user override the above settings.
 #
-- 
2.5.0.466.g9af26fa

Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[Jason]

Thanks for the fix John. All set now.

Build failed in Jenkins: cgit - upstream - get-git - master #190 - remotes/origin/master - a360666

[mailings]

I've talked to Jason and from now on my build server will also send 
email to the cgit-dev list upon build failures.

That might give some noise when I'm fiddling with the build server, but 
I'll try to avoid that.

On 13/08/15 17:05, Jason A. Donenfeld wrote:
> Thanks for the fix John. All set now.
>

-- 
Ferry Huberts