List for cgit developers and users
 help / color / mirror / Atom feed
Subject: [PATCH] Make default pages configurable
Date: Thu, 15 Aug 2019 12:56:28 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> Missing sign-off.  See for what this
> means.

Sorry, I didn't realise signing off was required. Is this mentioned somewhere,
or just a tacit convention in most open-source projects?

> The commit message also needs to explain *why* we want this change in
> addition to how the change is implemented.

The rationale for the change seemed pretty obvious, but I'll make sure to
include a sentence or two about it.

Should I send the new patch as a new thread, or simply reply to this one?

  reply	other threads:[~2019-08-15 10:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 17:22 
2019-08-15 10:26 ` john
2019-08-15 10:56   `  [this message]
2019-08-15 12:50   ` [PATCH v2] " 
2019-08-19  8:31     ` actionmystique
2019-08-19  9:44       ` 
2019-08-20  9:09         ` actionmystique
2019-08-20 11:28           ` 
2019-08-21 14:50             ` actionmystique

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).