List for cgit developers and users
 help / color / mirror / Atom feed
From: Jason at (Jason A. Donenfeld)
Subject: [PATCH 1/1] RFC: git: update to v2.18.0-rc2
Date: Sat, 16 Jun 2018 18:15:17 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Jun 16, 2018 at 6:14 PM John Keeping <john at> wrote:
> But we still have a few mentions of sha1 in our code.  Most of this is
> sha1 and sha2 in struct cgit_query, but these aren't actually hashes
> most of the time, they can be any object reference that Git understands,
> so I think we should rename them to ref1 and ref2 (along with has_sha1
> -> has_ref).  What do you think?

Yes, please. This is some excellent progress.

  reply	other threads:[~2018-06-16 16:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 22:52 list
2018-06-14  1:48 ` [PATCH] ui-shared: typename changed to type_name in git 2.18.0-rc2 andy
2018-06-16 16:14 ` [PATCH 1/1] RFC: git: update to v2.18.0-rc2 john
2018-06-16 16:15   ` Jason [this message]
2018-06-16 20:34   ` list
2018-06-18  6:10 ` list
2018-06-18  6:42   ` andy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).