filter rework break about page

filter rework break about page

[list]

Hello everybody,

commit 'filters: Simplify converters' (525c815) breaks the about page, it is
simply empty. Reverting the patch restores the expected behavior. I did not
yet analyze the issue.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151011/be1f62fa/attachment.asc>

filter rework break about page

[list]

Christian Hesse <list at eworm.de> on Sun, 2015/10/11 12:06:
> Hello everybody,
> 
> commit 'filters: Simplify converters' (525c815) breaks the about page, it is
> simply empty. Reverting the patch restores the expected behavior. I did not
> yet analyze the issue.

Ah, took me just some seconds... :D
Looks like markdown_py is expected, but my distribution (Arch Linux) install
it as markdown.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151011/3df66e19/attachment.asc>

filter rework break about page

[jason.donenfeld]

Feel free to submit a patch with some notice about that and/or some
autodetection logic for markdown/markdown_py. If not, I'll do it on Monday.
On Oct 11, 2015 12:08 PM, "Christian Hesse" <list at eworm.de> wrote:

> Christian Hesse <list at eworm.de> on Sun, 2015/10/11 12:06:
> > Hello everybody,
> >
> > commit 'filters: Simplify converters' (525c815) breaks the about page,
> it is
> > simply empty. Reverting the patch restores the expected behavior. I did
> not
> > yet analyze the issue.
>
> Ah, took me just some seconds... :D
> Looks like markdown_py is expected, but my distribution (Arch Linux)
> install
> it as markdown.
> --
> main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
> "CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
> putchar(b-1/(/*               gcc -o sig sig.c && ./sig
> */b/42*2-3)*42);}
>
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151011/bdbaacbb/attachment.html>

filter rework break about page

[list]

Christian Hesse <list at eworm.de> on Sun, 2015/10/11 12:08:
> Christian Hesse <list at eworm.de> on Sun, 2015/10/11 12:06:
> > Hello everybody,
> > 
> > commit 'filters: Simplify converters' (525c815) breaks the about page, it
> > is simply empty. Reverting the patch restores the expected behavior. I
> > did not yet analyze the issue.  
> 
> Ah, took me just some seconds... :D
> Looks like markdown_py is expected, but my distribution (Arch Linux) install
> it as markdown.

And it does not accept -o switch... Just calling 'markdown' seems to work.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151011/e92d6ed0/attachment.asc>

filter rework break about page

[Jason]

What package is that from? Link to upstream?

filter rework break about page

[list]

"Jason A. Donenfeld" <Jason at zx2c4.com> on Sun, 2015/10/11 14:09:
> What package is that from? Link to upstream?

https://www.archlinux.org/packages/community/any/markdown/
http://daringfireball.net/projects/markdown/
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151011/fe8fadaa/attachment.asc>

filter rework break about page

[Jason]

Oh. Right. That's the slow script I replaced, preferring instead markdown_py:
https://www.archlinux.org/packages/community/any/python-markdown/
That's the package you want.

I should include some documentation for this.

I will also soon recode that script to be pure python, instead of bash
shelling out to python. This will also allow inline syntax
highlighting.

filter rework break about page

[list]

Christian Hesse <list at eworm.de> on Sun, 2015/10/11 18:13:
> "Jason A. Donenfeld" <Jason at zx2c4.com> on Sun, 2015/10/11 14:09:
> > What package is that from? Link to upstream?  
> 
> https://www.archlinux.org/packages/community/any/markdown/
> http://daringfireball.net/projects/markdown/

Just a little heads up...

The python version you use is available as 'python-markdown' in Arch Linux.
Installing that one makes everything work as expected.

May be interesting to have an option to specify a command and its options,
though. Discount [0] is just another implementation written in plain C. That
could bring some more performance improvements.

And having a fallback to just pass the text as-is would be nice as well.
Currently if markdown is not available the about page is just empty.

[0] http://www.pell.portland.or.us/~orc/Code/discount/
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151012/f9f7f818/attachment.asc>

filter rework break about page

[list]

Christian Hesse <list at eworm.de> on Mon, 2015/10/12 11:57: 
> May be interesting to have an option to specify a command and its options,
> though. Discount [0] is just another implementation written in plain C. That
> could bring some more performance improvements.
> 
> [...]
>
> [0] http://www.pell.portland.or.us/~orc/Code/discount/

BTW, this brings a shared library libmarkdown.so. We could link cgit against
that and handle markdown without external command.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20151012/0c2198f3/attachment.asc>

filter rework break about page

[Jason]

On Mon, Oct 12, 2015 at 1:05 PM, Christian Hesse <list at eworm.de> wrote:
>> [0] http://www.pell.portland.or.us/~orc/Code/discount/
>
> BTW, this brings a shared library libmarkdown.so. We could link cgit against
> that and handle markdown without external command.

Definitely not. In the first case, I wouldn't want to special case
this. Though, I wouldn't mind adding support for *yet another filter
type* - dlopen. Nonetheless, Lua serves the highspeed case rather
well. But in fact my real concern is that different sites have wildly
differing requirements on what kind of markdown they output. Github
flavored? Italics within words? Should it filter out dangerous HTML?
Etc. Too many decisions, that are best off to a tweakable script.