List for cgit developers and users
 help / color / mirror / Atom feed
From: actionmystique at gmail.com (jean-christophe manciot)
Subject: [PULL REQUEST] Make default pages configurable
Date: Sat, 21 Dec 2019 13:38:44 +0100	[thread overview]
Message-ID: <CAKcFC3bFrtD_avdhOAnnnSJY=rc7YpXLGhd62YhniHuzfvY_mw@mail.gmail.com> (raw)
In-Reply-To: <fc132538-f341-6cab-bb77-2872b76b1bda@layeh.com>

It is useful indeed, I use it for my public site <https://git.sdxlive.com/>
since it was proposed.
But it appears that making it to the cgit git sources as a commit is a
different story.
Maybe the admin(s) could share the policies which make a patch eligible to
the commit status on the master branch, such as:
- being useful to the community
- having passed some thorough functional tests
- having passed some thorough security tests
- ...
What about adding an official development branch?.

On Sat, Dec 21, 2019 at 3:22 AM Tim Cooper <tim.cooper at layeh.com> wrote:

> I would find this feature useful as well.
>
> ---
> Tim Cooper
>
> On 12/9/19 12:47 PM, fnaim42 at gmail.com (Na?m Favier) wrote:
> > I proposed this change a while ago, but it didn't seem to get much
> > attention. Please tell me if I'm doing something wrong.
> >
> > It would be nice to be able to configure the default page to use for the
> > root site and repositories. For example, it might make more sense to
> > have "about" or "tree" as the default landing page for certain repos,
> > instead of the default "summary".
> >
> > This patch introduces the following configuration settings:
> > - "root-default-page": sets the default page for the root site
> >    (defaults to "repolist")
> > - "repo.default-page": sets the default page for individual repos
> >    (defaults to "summary")
> > - "default-page": global default value for "repo.default-page"
> >
> > The following accessory changes were required to make this work:
> > - the "index" tab link on root pages and the "summary" tab link on repo
> >    pages now explicitly point to their respective targets instead of
> >    pointing to the site/repo root
> > - trying to access the "about" page on a repository without one results
> >    in being redirected to the "summary" page explicitly
> >
> > The following changes since commit
> 8fc0c81bbbed21ee30e8a48b2ab1066a029b7b32:
> >
> >    git: update to v2.23.0 (2019-10-25 11:40:17 +0200)
> >
> > are available in the Git repository at:
> >
> >    https://git.monade.li/cgit
> >
> > for you to fetch changes up to 1431881898ba6044bfd3ae12cc45fb5fcadf80c7:
> >
> >    Make default pages configurable (2019-12-09 19:38:14 +0100)
> >
> > ----------------------------------------------------------------
> > Na?m Favier (1):
> >        Make default pages configurable
> >
> >   cgit.c        | 10 ++++++++++
> >   cgit.h        |  3 +++
> >   cgitrc.5.txt  | 14 ++++++++++++++
> >   cmd.c         | 18 +++++++++---------
> >   ui-repolist.c |  2 +-
> >   ui-shared.c   | 12 +++++++++---
> >   ui-shared.h   |  2 ++
> >   7 files changed, 48 insertions(+), 13 deletions(-)
> >
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/cgit
>


-- 
Jean-Christophe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20191221/00f667d8/attachment.html>


      reply	other threads:[~2019-12-21 12:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 18:47 
2019-12-21  2:22 ` tim.cooper
2019-12-21 12:38   ` actionmystique [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKcFC3bFrtD_avdhOAnnnSJY=rc7YpXLGhd62YhniHuzfvY_mw@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).