List for cgit developers and users
 help / color / mirror / Atom feed
* Greater use of the HTML title (for tabs and title bars) in cgit
@ 2022-11-06 11:01 Graham Perrin
  2022-11-06 12:44 ` John Keeping
  2022-11-06 14:06 ` june
  0 siblings, 2 replies; 4+ messages in thread
From: Graham Perrin @ 2022-11-06 11:01 UTC (permalink / raw)
  To: cgit


[-- Attachment #1.1: Type: text/plain, Size: 787 bytes --]

<https://lists.zx2c4.com/pipermail/cgit/2016-June/003088.html> for 1.0 
included:

> * Show reverse paths in title bar so that browser tab shows filename.

Please, are there plans to broaden/refine use of titles?

Early thoughts (with examples):

The title of 
<https://cgit.freebsd.org/src/commit/?id=a1017358b35e81ce2057ebf06d00b83cdb7f9ac9> 
could show:

* part of the first (summary) line of the message, abbreviated … if more 
than fifty characters

* the branch (not main)

* the short hash.

<https://cgit.freebsd.org/src/tree/sbin/tunefs/tunefs.8?id=a1017358b35e81ce2057ebf06d00b83cdb7f9ac9>, 
currently:

> tunefs.8 « tunefs « sbin - src - FreeBSD source tree
– might additionally show:

* the branch (not main)

* the short hash.

Thanks


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Greater use of the HTML title (for tabs and title bars) in cgit
  2022-11-06 11:01 Greater use of the HTML title (for tabs and title bars) in cgit Graham Perrin
@ 2022-11-06 12:44 ` John Keeping
  2022-11-06 13:53   ` Gianni Ceccarelli
  2022-11-06 14:06 ` june
  1 sibling, 1 reply; 4+ messages in thread
From: John Keeping @ 2022-11-06 12:44 UTC (permalink / raw)
  To: Graham Perrin; +Cc: cgit

Hi Graham,

On Sun, Nov 06, 2022 at 11:01:25AM +0000, Graham Perrin wrote:
> <https://lists.zx2c4.com/pipermail/cgit/2016-June/003088.html> for 1.0
> included:
> 
> > * Show reverse paths in title bar so that browser tab shows filename.
> 
> Please, are there plans to broaden/refine use of titles?

There are no plans - but patches are welcome :-)

> Early thoughts (with examples):
> 
> The title of <https://cgit.freebsd.org/src/commit/?id=a1017358b35e81ce2057ebf06d00b83cdb7f9ac9>
> could show:
> 
> * part of the first (summary) line of the message, abbreviated … if more
> than fifty characters

This seems useful and is probably easy to add.

> * the branch (not main)

Git commits are not associated with a branch, so unless we have an h=...
query argument I don't see any way to derive the correct value to
display for a branch.


Regards,
John

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Greater use of the HTML title (for tabs and title bars) in cgit
  2022-11-06 12:44 ` John Keeping
@ 2022-11-06 13:53   ` Gianni Ceccarelli
  0 siblings, 0 replies; 4+ messages in thread
From: Gianni Ceccarelli @ 2022-11-06 13:53 UTC (permalink / raw)
  To: cgit

On 2022-11-06 John Keeping <john@metanate.com> wrote:
> > * the branch (not main)  
> 
> Git commits are not associated with a branch, so unless we have an
> h=... query argument I don't see any way to derive the correct value
> to display for a branch.

We could do the equivalent of ``git branch --contains $commit``, but:

- it's expensive
- it returns a list of heads

So I agree that the best source of branch name is the ``h=`` argument.

-- 
	Dakkar - <Mobilis in mobile>
	GPG public key fingerprint = A071 E618 DD2C 5901 9574
	                             6FE2 40EA 9883 7519 3F88
	                    key id = 0x75193F88


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Greater use of the HTML title (for tabs and title bars) in cgit
  2022-11-06 11:01 Greater use of the HTML title (for tabs and title bars) in cgit Graham Perrin
  2022-11-06 12:44 ` John Keeping
@ 2022-11-06 14:06 ` june
  1 sibling, 0 replies; 4+ messages in thread
From: june @ 2022-11-06 14:06 UTC (permalink / raw)
  To: Graham Perrin; +Cc: cgit

> On Nov 6, 2022, at 06:01, Graham Perrin <grahamperrin@freebsd.org> wrote:
> 
> The title of <https://cgit.freebsd.org/src/commit/?id=a1017358b35e81ce2057ebf06d00b83cdb7f9ac9> could show:
> 
> * part of the first (summary) line of the message, abbreviated … if more than fifty characters

I sent a patch for this years ago which was ignored like all others.

https://git.causal.agency/cgit-pink/commit/?id=8f9034884bb592a0514d85771bd0096b1584b552


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-06 14:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-06 11:01 Greater use of the HTML title (for tabs and title bars) in cgit Graham Perrin
2022-11-06 12:44 ` John Keeping
2022-11-06 13:53   ` Gianni Ceccarelli
2022-11-06 14:06 ` june

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).