From: Dilyan.Palauzov at aegee.org (Dilyan Palauzov)
Subject: Slash after /about
Date: Wed, 30 Jan 2019 18:53:45 +0100 [thread overview]
Message-ID: <F142AE6B-C19A-479B-A3C2-317230C4D142@aegee.org> (raw)
In-Reply-To: <01602cde-7227-36df-7ad9-15dcad9b083f@necoro.eu>
Hello Ren?,
in case of cgit /repo/about/ and /repo/about are the same, except the latter causes a redirect to the former.
I propose removing the redirect and handling them as equal.
Regards
?????
On January 29, 2019 7:58:26 PM GMT+01:00, "Ren? Neumann" <lists at necoro.eu> wrote:
>Hi,
>
>without saying anything about the particular change, I find the
>behavior of thttpd in this regard to be slighly irritating: I know more
>
>than one software, where 'bar/foo' and 'bar/foo/' might represent two
>different things (mostly the former being 'service bar with argument
>foo' and the latter being 'service bar/foo with an empty argument').
>
>- Ren?
>
>On 29.01.19 10:21, ????? ???????? wrote:
>> Hello,
>>
>> For CGI I use thttpd and it tends to remove terminating slashes in
>the requests.
>>
>> cgit wants to have slash after about/ .
>>
>> So they do not work together, endless loop happens. Proposed fix:
>>
>> diff --git a/cmd.c b/cmd.c
>> --- a/cmd.c
>> +++ b/cmd.c
>> @@ -40,16 +40,7 @@ static void atom_fn(void)
>> static void about_fn(void)
>> {
>> if (ctx.repo) {
>> - size_t path_info_len = ctx.env.path_info ?
>strlen(ctx.env.path_info) : 0;
>> - if (!ctx.qry.path &&
>> - ctx.qry.url[strlen(ctx.qry.url) - 1] != '/' &&
>> - (!path_info_len ||
>ctx.env.path_info[path_info_len - 1] != '/')) {
>> - char *currenturl = cgit_currenturl();
>> - char *redirect = fmtalloc("%s/", currenturl);
>> - cgit_redirect(redirect, true);
>> - free(currenturl);
>> - free(redirect);
>> - } else if (ctx.repo->readme.nr)
>> + if (ctx.repo->readme.nr)
>> cgit_print_repo_readme(ctx.qry.path);
>> else if (ctx.repo->homepage)
>> cgit_redirect(ctx.repo->homepage, false);
>>
>>
>>
>> Apart of this the alphabetical sort order of the options in cgitrc.5
>is violated by case-sensitive-sort, it shall not be
>> between cache-size and cache-scanrc-ttl .
>>
>> Regards
>> ?????
>>
>> _______________________________________________
>> CGit mailing list
>> CGit at lists.zx2c4.com
>> https://lists.zx2c4.com/mailman/listinfo/cgit
>>
>_______________________________________________
>CGit mailing list
>CGit at lists.zx2c4.com
>https://lists.zx2c4.com/mailman/listinfo/cgit
next prev parent reply other threads:[~2019-01-30 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 9:21
2019-01-29 18:58 `
2019-01-30 17:53 ` Dilyan.Palauzov [this message]
2019-01-30 18:37 ` john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F142AE6B-C19A-479B-A3C2-317230C4D142@aegee.org \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).