From: John Keeping <john@keeping.me.uk>
To: "Paul W. Rankin" <pwr@bydasein.com>
Cc: cgit@lists.zx2c4.com
Subject: Re: OpenBSD - Error reading owner-info for <REPOPATH>: No such file or directory (2)
Date: Thu, 25 Feb 2021 10:26:05 +0000 [thread overview]
Message-ID: <YDd7PZQIwIKGSPht@john.keeping.me.uk> (raw)
In-Reply-To: <a67b23cad9d7a47691c6828ad561de3b@bydasein.com>
On Thu, Feb 25, 2021 at 05:00:57PM +1000, Paul W. Rankin wrote:
> I'm running cgit v1.2.3 on OpenBSD 6.8 with httpd and slowcgi. I'm
> getting tons of log errors in the form:
> Error reading owner-info for <REPOPATH>: No such file or directory
> (2)
>
> I've found this Stack Overflow question
> https://stackoverflow.com/questions/48450631/ which suggests that the
> problem is with the call to getpwuid trying to access /etc/passwd:
>
> if ((pwd = getpwuid(st.st_uid)) == NULL) {
> fprintf(stderr, "Error reading owner-info for %s: %s (%d)\n",
> path->buf, strerror(errno), errno);
> break;
> }
>
> @ https://git.zx2c4.com/cgit/tree/scan-tree.c#n139
>
> On OpenBSD, httpd runs in a chroot at /var/www, which would seem to
> suggest why cgit would not be able to access /etc/passwd
>
> In my cgitrc I have
> enable-git-config=0
> enable-index-owner=0
> so that doesn't help.
>
> Is there any way to prevent all these error logs? Currently this fills
> up a log file about once an hour...
Without any changes to the code, if you set "repo.owner" (or
"gitweb.owner" if you have "enable-git-config" set) then this value will
be used and the loop that tries getpwuid() won't be entered.
I think it would be reasonable to provide a way to disable the "owner
from filesystem" code via cgitrc. It's probably meaningless in many
setups, for example with Gitolite, where all the repositories are owned
by a "git" user anyway.
John
next prev parent reply other threads:[~2021-02-25 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 7:00 Paul W. Rankin
2021-02-25 10:26 ` John Keeping [this message]
2021-02-25 12:09 ` Paul W. Rankin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDd7PZQIwIKGSPht@john.keeping.me.uk \
--to=john@keeping.me.uk \
--cc=cgit@lists.zx2c4.com \
--cc=pwr@bydasein.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).