From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] cgitrc.5: fix auth filter return value documentation
Date: Sat, 16 Jun 2018 17:31:32 +0100 [thread overview]
Message-ID: <c6c966edc6844d65b13e88fc6beb62a5b184c999.1529166649.git.john@keeping.me.uk> (raw)
In-Reply-To: <CAD_qbBhNb7ZaMSK+SxY_dDuzub+OXzFVpu1t+2Tpy1qbdUnegw@mail.gmail.com>
We don't treat all return values as invalid!
Signed-off-by: John Keeping <john at keeping.me.uk>
---
cgitrc.5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cgitrc.5.txt b/cgitrc.5.txt
index 4da166c..3e53bbd 100644
--- a/cgitrc.5.txt
+++ b/cgitrc.5.txt
@@ -715,7 +715,7 @@ auth filter::
When the filter action is "body", this filter must write to output the
HTML for displaying the login form, which POSTs to the login url. When
the filter action is "authenticate-cookie", this filter must validate
- the http cookie and return a 0 if it is invalid or 1 if it is invalid,
+ the http cookie and return a 0 if it is invalid or 1 if it is valid,
in the exit code / close function. If the filter action is
"authenticate-post", this filter receives POST'd parameters on
standard input, and should write a complete CGI response, preferably
--
2.17.1
prev parent reply other threads:[~2018-06-16 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 20:27 Documentation Typo ssamm1545
2018-06-16 16:31 ` john [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c966edc6844d65b13e88fc6beb62a5b184c999.1529166649.git.john@keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).