* Documentation Typo
@ 2018-04-16 20:27 ssamm1545
2018-06-16 16:31 ` [PATCH] cgitrc.5: fix auth filter return value documentation john
0 siblings, 1 reply; 2+ messages in thread
From: ssamm1545 @ 2018-04-16 20:27 UTC (permalink / raw)
I noticed there is a typo in cgitrc.5.txt on line 718
the http cookie and return a 0 if it is invalid or 1 if it is invalid,
should say
the http cookie and return a 0 if it is invalid or 1 if it is valid,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180416/b4d11901/attachment.html>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] cgitrc.5: fix auth filter return value documentation
2018-04-16 20:27 Documentation Typo ssamm1545
@ 2018-06-16 16:31 ` john
0 siblings, 0 replies; 2+ messages in thread
From: john @ 2018-06-16 16:31 UTC (permalink / raw)
We don't treat all return values as invalid!
Signed-off-by: John Keeping <john at keeping.me.uk>
---
cgitrc.5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cgitrc.5.txt b/cgitrc.5.txt
index 4da166c..3e53bbd 100644
--- a/cgitrc.5.txt
+++ b/cgitrc.5.txt
@@ -715,7 +715,7 @@ auth filter::
When the filter action is "body", this filter must write to output the
HTML for displaying the login form, which POSTs to the login url. When
the filter action is "authenticate-cookie", this filter must validate
- the http cookie and return a 0 if it is invalid or 1 if it is invalid,
+ the http cookie and return a 0 if it is invalid or 1 if it is valid,
in the exit code / close function. If the filter action is
"authenticate-post", this filter receives POST'd parameters on
standard input, and should write a complete CGI response, preferably
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-16 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 20:27 Documentation Typo ssamm1545
2018-06-16 16:31 ` [PATCH] cgitrc.5: fix auth filter return value documentation john
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).