Computer Old Farts Forum
 help / color / mirror / Atom feed
From: Adam Thornton <athornton@gmail.com>
To: Larry McVoy <lm@mcvoy.com>
Cc: COFF <coff@tuhs.org>
Subject: [COFF] Re: [TUHS] Interview question
Date: Mon, 2 Jan 2023 23:16:42 -0700	[thread overview]
Message-ID: <5A66D49E-56F8-499A-B4E3-6673570B25EA@gmail.com> (raw)
In-Reply-To: <20230103025836.GZ25547@mcvoy.com>



> On Jan 2, 2023, at 7:58 PM, Larry McVoy <lm@mcvoy.com> wrote:
> 
> On Mon, Jan 02, 2023 at 02:13:45PM -0700, Adam Thornton wrote:
>> 
>> 
>> Which of these, if any, do you count?
> 
> Any of them that are entirely done by you.

Well, then, all of the ones I listed, if you'll spot me the Fellowship Of The Ring Atari 2600 cartridge before Thomas Jentzsch got me a little more display space, even though the cartridge you can buy (and the sources available online) are the later version.

None of those are world-changing, and, for instance, I'm a lot more proud of the current state of JupyterHub Kubespawner, which wasn't mine to start with, but first I added per-user namespaces and upstreamed that, and then I changed it from threads to coroutines, and upstreamed _that_.  The second change has made it a lot more reliable for everyone (the first was useful for Rubin Observatory and people doing things like we do, but not generally useful for JupyterHub under Kubernetes).  But both of those were building on (a lot of) existing work and were also made a whole lot better by review commentary from my team.  Special thanks to Russ Allbery who was quoted on TUHS a couple days ago, who really, really helped with the thread->coroutine conversion.

Sure, I can do decent work on my own, but other people helping me out improves it immensely.  I know that I tend to: a) under-test, b) write huge functions and source files when I should be doing things with more granularity, c) write like it's 1979 and keystrokes are precious and use nondescriptive variable names which make things hard to read.  Review of my work helps with all of these.

Adam

  parent reply	other threads:[~2023-01-03  6:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230102203646.GT25547@mcvoy.com>
2023-01-02 21:13 ` Adam Thornton
2023-01-03  2:58   ` Larry McVoy
2023-01-03  6:06     ` Dave Horsfall
2023-01-03  6:16     ` Adam Thornton [this message]
2023-01-03 15:57     ` Warner Losh
2023-01-03 19:53       ` segaloco via COFF
2023-01-04  2:44       ` Bakul Shah
2023-01-04  3:06         ` Larry McVoy
2023-01-04 15:42           ` Dan Cross
2023-01-04 16:00             ` Warner Losh
2023-01-04 16:52               ` Dan Cross
2023-01-04 17:51               ` Adam Thornton
2023-01-04 16:06             ` Larry McVoy
2023-01-04 16:58               ` segaloco via COFF

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A66D49E-56F8-499A-B4E3-6673570B25EA@gmail.com \
    --to=athornton@gmail.com \
    --cc=coff@tuhs.org \
    --cc=lm@mcvoy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).