bug in message-encode-message-body

bug in message-encode-message-body

[Shenghuo ZHU]

In message.el (message-encode-message-body) of PG 0.22

	  (message-narrow-to-headers)
	  (goto-char (point-max))
	  (setq charset (or charset (mm-mule-charset-to-mime-charset 'ascii)))
	  ;; We don't insert MIME headers if they only say the default.
->	  (unless (and (eq charset 'ascii) 
		       (eq encoding '7bit))
	    (mm-insert-rfc822-headers charset encoding))
	  (mm-encode-body))))))

In the "->" line, 'charset' has been set to mime-charset value,
i.e. us-ascii or other. In this case, rfc822-headers of "us-ascii
7bit" are inserted to most mails. I guess this is a bug.

Moreover, "message-encode-message-body" is called twice by
"message-send", when the mail with a "Gcc" field. During The second
encoding, rfc822-headers are added to the tail of archived
mail. Actually, the second headers are always "us-ascii 7bit", since
the mail body has been encoded. The follows are backtracks of two
calls of "message-encode-message-body".

* message-encode-message-body()
  message-send-mail(nil)
  message-send-via-mail(nil)
  message-send(nil)
  message-send-and-exit(nil)
* call-interactively(message-send-and-exit)

* message-encode-message-body()
  gnus-request-accept-article("nnml:mail.sent" "archive" t)
  gnus-inews-do-gcc()
  run-hooks(message-sent-hook)
  message-send(nil)
  message-send-and-exit(nil)
* call-interactively(message-send-and-exit)

-- 
Shenghuo

Re: bug in message-encode-message-body

[Lars Magne Ingebrigtsen]

Shenghuo ZHU <zsh@cs.rochester.edu> writes:

> In the "->" line, 'charset' has been set to mime-charset value,
> i.e. us-ascii or other. In this case, rfc822-headers of "us-ascii
> 7bit" are inserted to most mails. I guess this is a bug.

Yup.  Fix in Pterodactyl Gnus v0.24.

> Moreover, "message-encode-message-body" is called twice by
> "message-send", when the mail with a "Gcc" field.

Ditto.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen