[patch] extremely minor aesthetics in nnrss.el

[patch] extremely minor aesthetics in nnrss.el

[Andrew J Cosgriff]

This is entirely frivolous, but now the whole world can know we're
using Gnus to read our RSS feeds.  Instead of this :

somewhere - - [24/Apr/2002:13:52:50 +1000] "GET /blah.rss HTTP/1.0" 200 45224 "-" "Unknown/Unknown URL/p4.0pre.46 (i686-pc-linux; X11)"

we now get this :

somewhere - - [24/Apr/2002:14:07:29 +1000] "GET /blah.rss HTTP/1.0" 200 45224 "-" "OortGnus/0.06 URL/p4.0pre.46 (i686-pc-linux; X11)"


Enjoy,
 Andrew


Index: nnrss.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnrss.el,v
retrieving revision 6.28
diff -u -1 -b -p -r6.28 nnrss.el
--- nnrss.el	2002/02/20 00:15:32	6.28
+++ nnrss.el	2002/04/24 04:13:03
@@ -452,4 +504,6 @@ ARTICLE is the article number of the cur
 (defun nnrss-insert-w3 (url)
+  (let ((url-package-name (replace-in-string (replace-in-string gnus-version " v.*$" "") " " ""))
+    (url-package-version gnus-version-number))
   (mm-with-unibyte-current-buffer
-    (mm-url-insert url)))
+    (mm-url-insert url))))
 


-- 
Andrew J Cosgriff <ajc@polydistortion.net>
surprise sun amnesia hope lies

Re: [patch] extremely minor aesthetics in nnrss.el

[Andrew J Cosgriff]

ajc wrote :

> This is entirely frivolous, but now the whole world can know we're
> using Gnus to read our RSS feeds.  Instead of this :

dang. somewhere in the fuzz between my ears I remembered that emacs 20
doesn't have replace-in-string, does it ?

and emacs 21 seems to have a "replace-regexp-in-string", instead.

um.  hmm.

*grep*

Ah.  Gnus already had/solved this problem.  Well, in that case :


Index: nnrss.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnrss.el,v
retrieving revision 6.28
diff -u -1 -b -p -r6.28 nnrss.el
--- nnrss.el	2002/02/20 00:15:32	6.28
+++ nnrss.el	2002/04/24 07:59:52
@@ -452,4 +504,6 @@ ARTICLE is the article number of the cur
 (defun nnrss-insert-w3 (url)
+  (let ((url-package-name (gnus-replace-in-string (gnus-replace-in-string gnus-version " v.*$" "") " " ""))
+    (url-package-version gnus-version-number))
   (mm-with-unibyte-current-buffer
-    (mm-url-insert url)))
+    (mm-url-insert url))))
 

Er.  Sorry about that.

-- 
Andrew J Cosgriff <ajc@polydistortion.net>
butter moon fun 1970s tunnel

Re: [patch] extremely minor aesthetics in nnrss.el

[ShengHuo ZHU]

Andrew J Cosgriff <ajc@polydistortion.net> writes:

> ajc wrote :
>
>> This is entirely frivolous, but now the whole world can know we're
>> using Gnus to read our RSS feeds.  Instead of this :
>
> dang. somewhere in the fuzz between my ears I remembered that emacs 20
> doesn't have replace-in-string, does it ?
>
> and emacs 21 seems to have a "replace-regexp-in-string", instead.
>
> um.  hmm.
>
> *grep*
>
> Ah.  Gnus already had/solved this problem.  Well, in that case :

I installed it into mm-url.el instead of nnrss.el. Thanks.

ShengHuo

Re: [patch] extremely minor aesthetics in nnrss.el

[Andrew J Cosgriff]

ShengHuo ZHU wrote :

[...my user-agent patch...]

> I installed it into mm-url.el instead of nnrss.el. Thanks.

sure.  I thought about putting it there, but wasn't sure if mm-url was
likely to be used by non-gnus stuff, in which case they might like to
set their own user-agent instead ?  not that it /really/ matters,
though.

-- 
Andrew J Cosgriff <ajc@polydistortion.net>
why prozac cola spandex metal