mml-preview is bugging out these days

mml-preview is bugging out these days

[Karl Kleinpaste]

An X-Face problem.  And the full colorization and other rendering of
the header is not completed.

Signaling: (args-out-of-range #<buffer "*MIME preview of mail to gnost"> 0 1)
  make-extent(0 1)
  gnus-put-image(#<glyph (buffer) #<image-specifier global=(... ... ...) fallback=(...) 0x10fb1>0x10fb0>)
  gnus-display-x-face-in-from("?=p^Gj2JkX~UU_@W}[q/'Dxn19x-zfIQ](y<&ky/?1-&Nz&,!W}R.Gp+\"LeGojoR\n	=RF>?!XVs{a:`Yt(gqM<#$Zy(C@]'dR4Hy4S1.I(n3:2\"R:=Uy!)K9>U!gNTyH{p\n	+_w#F[gt).$Vyvo5=9LF^PeQ(@H#}QLAbfyYxX/8t:TDR5nA\\|RmJO\"EwjL8tWyvM\n")
  article-display-x-face()
  apply(article-display-x-face nil)
  (if interactive (call-interactively (quote article-display-x-face)) (apply (quote article-display-x-face) args))
  (save-excursion (set-buffer gnus-article-buffer) (if interactive (call-interactively ...) (apply ... args)))
  gnus-article-display-x-face()
  gnus-treat-article(head)
  gnus-display-mime()
  gnus-article-prepare-display()
  mml-preview(nil)
  call-interactively(mml-preview)

Re: mml-preview is bugging out these days

[ShengHuo ZHU]

Karl Kleinpaste <karl@charcoal.com> writes:

> An X-Face problem.  And the full colorization and other rendering of
> the header is not completed.
>
> Signaling: (args-out-of-range #<buffer "*MIME preview of mail to gnost"> 0 1)
>   make-extent(0 1)

Fixed.

ShengHuo

Re: mml-preview is bugging out these days

[Karl Kleinpaste]

Karl Kleinpaste <karl@charcoal.com> writes:
>> Signaling: (args-out-of-range #<buffer "*MIME preview of mail to gnost"> 0 1)
>>   make-extent(0 1)

ShengHuo ZHU <zsh@cs.rochester.edu> writes:
> Fixed.

Thank you.

Now, previews, as well as articles in nndraft:drafts, are showing up
with a differently messed up header, reading as:

       From:Subject: Some Subject Here

where the From: has been lost (well, there isn't one in the first
place, usually) and stuck to gether with the Subject.

Re: mml-preview is bugging out these days

[ShengHuo ZHU]

Karl Kleinpaste <karl@charcoal.com> writes:

> Karl Kleinpaste <karl@charcoal.com> writes:
>>> Signaling: (args-out-of-range #<buffer "*MIME preview of mail to gnost"> 0 1)
>>>   make-extent(0 1)
>
> ShengHuo ZHU <zsh@cs.rochester.edu> writes:
>> Fixed.
>
> Thank you.
>
> Now, previews, as well as articles in nndraft:drafts, are showing up
> with a differently messed up header, reading as:
>
>        From:Subject: Some Subject Here
>
> where the From: has been lost (well, there isn't one in the first
> place, usually) and stuck to gether with the Subject.

It seems fine for me. "From: \n" is inserted if not exist, but it
seems the NL is invisible in your article buffer. I am not sure
why. Could you debug it? The code is in gnus-display-x-face-in-from.

ShengHuo

Re: mml-preview is bugging out these days

[Karl Kleinpaste]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

ShengHuo ZHU <zsh@cs.rochester.edu> writes:
> It seems fine for me. "From: \n" is inserted if not exist, but it
> seems the NL is invisible in your article buffer. I am not sure
> why. Could you debug it? The code is in gnus-display-x-face-in-from.

article-hide-boring-headers in gnus-art.el is (correctly) determining
that gnus-display-x-face-in-from's faked "From" line is empty, so it
is trying to remove it from visibility.  I don't know why it doesn't
get rid of the entire line; I didn't chase the problem that far.  The
patch below is a somewhat tacky but adequate fix to the problem.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-fun.diff --]
[-- Type: text/x-patch, Size: 372 bytes --]

--- lisp/gnus-fun.el.~1~	Mon Jan  7 12:45:32 2002
+++ lisp/gnus-fun.el	Fri Jan 11 17:36:54 2002
@@ -177,8 +177,8 @@
 	  (article-narrow-to-head)
 	  (gnus-article-goto-header "from")
 	  (when (bobp) 
-	    (insert "From: \n")
-	    (forward-char -2))
+	    (insert "From: [no `from' set]\n")
+	    (forward-char -17))
 	  (gnus-add-image
 	   'xface
 	   (gnus-put-image

[-- Attachment #3: Type: text/plain, Size: 66 bytes --]


It surprises me considerably that you don't see the misbehavior.

Re: mml-preview is bugging out these days

[ShengHuo ZHU]

Karl Kleinpaste <karl@charcoal.com> writes:

> ShengHuo ZHU <zsh@cs.rochester.edu> writes:
>> It seems fine for me. "From: \n" is inserted if not exist, but it
>> seems the NL is invisible in your article buffer. I am not sure
>> why. Could you debug it? The code is in gnus-display-x-face-in-from.
>
> article-hide-boring-headers in gnus-art.el is (correctly) determining
> that gnus-display-x-face-in-from's faked "From" line is empty, so it
> is trying to remove it from visibility.  I don't know why it doesn't
> get rid of the entire line; I didn't chase the problem that far.  The
> patch below is a somewhat tacky but adequate fix to the problem.

[...]

I'll install it.

> It surprises me considerably that you don't see the misbehavior.

Maybe I use a different version of XEmacs or some different treat
setting.

ShengHuo