From: Rod Whitby <list.ding@rwhitby.net>
Subject: Re: Archiving Inbox
Date: 07 Aug 2000 08:53:06 +0930 [thread overview]
Message-ID: <64lmya7z51.fsf@a11375-rw.asc.corp.mot.com> (raw)
In-Reply-To: <vaflmyd6ook.fsf@lucy.cs.uni-dortmund.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 5226 bytes --]
Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> On Fri, 04 Aug 2000, Harry Putnam wrote:
>
> > ((expiry-target . "nnml:target")
> > (expiry-wait . 21 ))
> >
> > ((expiry-target . "nnml:target)
> > (total-expire . t )
> > (expiry-wait . 14 ))
>
> I haven't tried this, but these settings look good. (That is, that's
> what I would have set if I wanted to try the feature.) Is there a bug
> in Gnus?
The functionality of setting nnmail-expiry-target to a string (i.e. a
group to which the expired articles should be moved, instead of being
deleted) just plain does not work. Therefore, there must be no-one
but me using it :-)
Anyway, here's some patches (against a pretty recent snapshot, and I
don't think anything around them has changed since) that do the
following:
1/ [gnus-sum.el, gnus-summary-expire-articles]
Fix the handling of expiry-target group parameters.
2/ [nnml.el, nnml-request-expire-articles]
Fix the calls to nnml-request-article (the filename was being
passed instead of the article number) and
nnmail-expiry-target-group (nnml-current-directory is changed by
nnml-request-accept-article, causing it to be incorrect for the
next article to be expired).
3/ [nnmail.el, nnmail-expiry-target-group]
Fix the call to gnus-request-accept-article so that body encoding
is *not* done. Encoding is not done on incoming mail, so why
should it be done on expired mail?
This is my first patch submission to the ding mailing list, so please
let me know if I should have submitted these in another format (in
particular, how do you get the nice ChangeLog entries?), and also how
I should proceed in getting these checked into CVS.
For those interested, the reason why I found these problems is because
I have just set up my nnml:INBOX to expire to a nnml:DELETED folder
immediately, and then the nnml:DELETED folder really deletes the
messages after a long time. Sort of like the Trash folder in
Netscape, only better :-) Now I can set display to 'all in my
nnml:INBOX group parameters and use the tick marks properly, while
still seeing my other unfiled mail when I enter the folder normally.
diff -c /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el~ /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el
*** /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el~ Tue Jul 25 05:56:17 2000
--- /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el Tue Jul 25 05:56:17 2000
***************
*** 7682,7687 ****
--- 7682,7690 ----
(expiry-wait (if now 'immediate
(gnus-group-find-parameter
gnus-newsgroup-name 'expiry-wait)))
+ (nnmail-expiry-target
+ (or (gnus-group-find-parameter gnus-newsgroup-name 'expiry-target)
+ nnmail-expiry-target))
es)
(when expirable
;; There are expirable articles in this group, so we run them
diff -c /gnu/XEmacs/site-packages/gnus/lisp/nnml.el~ /gnu/XEmacs/site-packages/gnus/lisp/nnml.el
*** /gnu/XEmacs/site-packages/gnus/lisp/nnml.el~ Tue Jul 25 05:07:35 2000
--- /gnu/XEmacs/site-packages/gnus/lisp/nnml.el Tue Jul 25 05:07:35 2000
***************
*** 289,300 ****
;; Allow a special target group.
(unless (eq nnmail-expiry-target 'delete)
(with-temp-buffer
! (nnml-request-article article group server
(current-buffer))
! (nnmail-expiry-target-group
! nnmail-expiry-target group)))
(nnheader-message 5 "Deleting article %s in %s"
! article group)
(condition-case ()
(funcall nnmail-delete-file-function article)
(file-error
--- 289,301 ----
;; Allow a special target group.
(unless (eq nnmail-expiry-target 'delete)
(with-temp-buffer
! (nnml-request-article number group server
(current-buffer))
! (let ((nnml-current-directory nil))
! (nnmail-expiry-target-group
! nnmail-expiry-target group))))
(nnheader-message 5 "Deleting article %s in %s"
! number group)
(condition-case ()
(funcall nnmail-delete-file-function article)
(file-error
diff -c /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el~ /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el
*** /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el~ Tue Jul 25 05:08:51 2000
--- /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el Tue Jul 25 05:08:51 2000
***************
*** 1610,1616 ****
(when (nnheader-functionp target)
(setq target (funcall target group)))
(unless (eq target 'delete)
! (gnus-request-accept-article target)))
(defun nnmail-check-syntax ()
"Check (and modify) the syntax of the message in the current buffer."
--- 1610,1616 ----
(when (nnheader-functionp target)
(setq target (funcall target group)))
(unless (eq target 'delete)
! (gnus-request-accept-article target nil nil t)))
(defun nnmail-check-syntax ()
"Check (and modify) the syntax of the message in the current buffer."
--
-- Rod Whitby, Snr Staff Engr, Electronic Design Automation --
-- Motorola Australia Software Centre - Adelaide, Australia --
-- Phone: +61 8 8203 3526, Fax: +61 8 8203 3501, <GMT+9:30> --
next prev parent reply other threads:[~2000-08-06 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <g0omngfw.fsf@lieckfeldt.net>
[not found] ` <vafd7jpedcp.fsf@lucy.cs.uni-dortmund.de>
2000-08-04 11:39 ` Harry Putnam
2000-08-04 15:17 ` Kai Großjohann
2000-08-04 17:55 ` Harry Putnam
2000-08-10 16:39 ` Kai Großjohann
2000-08-10 23:50 ` Rod Whitby
2000-08-06 23:23 ` Rod Whitby [this message]
2000-08-07 20:50 ` Arcady Genkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64lmya7z51.fsf@a11375-rw.asc.corp.mot.com \
--to=list.ding@rwhitby.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).