error on expiring

error on expiring

[Andrew Cohen]

I haven't updated from git for a few days. With an update from last
night I get an error when exiting a group that has (total-expire . t):


Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  gnus-add-to-range(((1 . 477)) (nil))
  gnus-compute-read-articles("nnimap+home:uhc.old.old" (nil))
  gnus-group-make-articles-read("nnimap+home:uhc.old.old" (nil))
  gnus-group-mark-article-read("nnimap+home:uhc.old.old" nil)
  nnmail-expiry-target-group("nnimap+home:uhc.old.old" "uhc.old")
  nnimap-process-expiry-targets((196 199 200 201 202 203 204 207) "uhc.old" "home")
  nnimap-request-expire-articles((1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 ...) "uhc.old" "home" nil)
  gnus-request-expire-articles((1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 ...) "nnimap+home:uhc.old")
  gnus-summary-expire-articles()
  run-hooks(gnus-summary-prepare-exit-hook)
  apply(run-hooks gnus-summary-prepare-exit-hook)
  gnus-run-hooks(gnus-summary-prepare-exit-hook)
  gnus-summary-exit()
  call-interactively(gnus-summary-exit nil nil)


In stepping through this, I find nnmail-expiry-target-group sets
group-art from gnus-request-accept-article with the value nil for the
article.

Let me know if I can be of more help.

Re: error on expiring

[Andrew Cohen]

I think I found the problem. Reverting this commit makes it work again
(I'm using dovecot for reference).

diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index 2f432a1..c256c8c 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -795,6 +795,7 @@ textual parts.")
 (deffoo nnimap-request-accept-article (group &optional server last)
   (when (nnimap-possibly-change-group nil server)
     (nnmail-check-syntax)
+    (nnimap-add-cr)
     (let ((message (buffer-string))
          (message-id (message-field-value "message-id"))
          sequence)

Re: error on expiring

[Dave Goldberg]

> I think I found the problem. Reverting this commit makes it work again
> (I'm using dovecot for reference).

> diff --git a/lisp/nnimap.el b/lisp/nnimap.el
> index 2f432a1..c256c8c 100644
> --- a/lisp/nnimap.el
> +++ b/lisp/nnimap.el
> @@ -795,6 +795,7 @@ textual parts.")
>  (deffoo nnimap-request-accept-article (group &optional server last)
>    (when (nnimap-possibly-change-group nil server)
>      (nnmail-check-syntax)
> +    (nnimap-add-cr)
>      (let ((message (buffer-string))
>           (message-id (message-field-value "message-id"))
>           sequence)

Reverting the commit will break GCC and article copy on a cyrus
server.  I'm not sufficiently elisp literate to know how to patch it,
but looking through my *imap log* I see that the \r\n (aka ^M) ends up
in the message-id being searched for in relevant UID SEARCH commands
and therefore the search is failing.  Stripping it from the search
string should solve the problem.

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: error on expiring

[Jason Riedy]

And Andrew Cohen writes:
> I haven't updated from git for a few days. With an update from last
> night I get an error when exiting a group that has (total-expire . t):

Same error on the current git exiting an imap group, and dovecot's the
backend.

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  gnus-add-to-range(((1 . 7964) 7968 (7970 . 7971)) (nil))
  gnus-compute-read-articles("nnimap+Local:Sonic.expired" (nil))
  gnus-group-make-articles-read("nnimap+Local:Sonic.expired" (nil))
  gnus-group-mark-article-read("nnimap+Local:Sonic.expired" nil)
  nnmail-expiry-target-group("nnimap+Local:Sonic.expired" "Sonic.INBOX")
  nnimap-process-expiry-targets((19010 19012) "Sonic.INBOX" "Local")
  nnimap-request-expire-articles((19010 19012) "Sonic.INBOX" "Local" nil)
  gnus-request-expire-articles((19010 19012) "nnimap+Local:Sonic.INBOX")
  gnus-summary-expire-articles()
  run-hooks(gnus-summary-prepare-exit-hook)
  apply(run-hooks gnus-summary-prepare-exit-hook)
  gnus-run-hooks(gnus-summary-prepare-exit-hook)
  gnus-summary-exit()
  call-interactively(gnus-summary-exit nil nil)

Jason

Re: error on expiring

[Lars Magne Ingebrigtsen]

Jason Riedy <jason@acm.org> writes:

> Same error on the current git exiting an imap group, and dovecot's the
> backend.
>
> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>   gnus-add-to-range(((1 . 7964) 7968 (7970 . 7971)) (nil))

This error should probably no longer happen, but I basically papered
over the error situation.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: error on expiring

[Jason Riedy]

And Lars Magne Ingebrigtsen writes:
> This error should probably no longer happen, but I basically papered
> over the error situation.

Thanks for the quick response, but now I see a different error:

Debugger entered: nil
  nnimap-request-set-mark("Sonic.expired" ((((1 . 7964) 7968 (7970 . 7971) (7976 . 7977) 7979 (7981 . 7987) (7989 . 7991) 7994 (7996 . 7997) (7999 . 8006) 8008 8010 (8014 . 8027) (8029 . 8031) (8034 . 8046) (8048 . 8049)) add (read))) "Local")
  gnus-request-set-mark("nnimap+Local:Sonic.expired" ((((1 . 7964) 7968 (7970 . 7971) (7976 . 7977) 7979 (7981 . 7987) (7989 . 7991) 7994 (7996 . 7997) (7999 . 8006) 8008 8010 (8014 . 8027) (8029 . 8031) (8034 . 8046) (8048 . 8049)) add (read))))
  gnus-group-make-articles-read("nnimap+Local:Sonic.expired" (8049))
  gnus-group-mark-article-read("nnimap+Local:Sonic.expired" 8049)
  nnmail-expiry-target-group("nnimap+Local:Sonic.expired" "Sonic.INBOX")
  nnimap-process-expiry-targets((19121) "Sonic.INBOX" "Local")
  nnimap-request-expire-articles((19121) "Sonic.INBOX" "Local" nil)
  gnus-request-expire-articles((19121) "nnimap+Local:Sonic.INBOX")
  gnus-summary-expire-articles()
  run-hooks(gnus-summary-prepare-exit-hook)
  apply(run-hooks gnus-summary-prepare-exit-hook)
  gnus-run-hooks(gnus-summary-prepare-exit-hook)
  gnus-summary-exit()
  call-interactively(gnus-summary-exit nil nil)

Jason

Re: error on expiring

[Jason Riedy]

And Jason Riedy writes:
> Thanks for the quick response, but now I see a different error:
[...]

Which has gone away on the latest master.  Odd, but thanks!

Jason