From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: spam-stat warning
Date: Wed, 01 Jun 2011 08:09:31 -0500 [thread overview]
Message-ID: <871uzdwvec.fsf@lifelogs.com> (raw)
In-Reply-To: <m3tycazieo.fsf@quimbies.gnus.org>
On Tue, 31 May 2011 23:09:35 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
LMI> On each Gnus startup I now get the following warning in Emacs 24:
LMI> Warning: defvar ignored because spam-stat-install-hooks is let-bound
LMI> And this is the reason:
LMI> (eval-and-compile
LMI> (when (condition-case nil
LMI> (let ((spam-stat-install-hooks nil))
LMI> (require 'spam-stat))
LMI> (file-error
LMI> (defalias 'spam-stat-register-ham-routine 'ignore)
LMI> (defalias 'spam-stat-register-spam-routine 'ignore)
LMI> nil))
LMI> And this is because:
LMI> (when spam-stat-install-hooks
LMI> (spam-stat-install-hooks-function))
LMI> I think that this may be a misfeature. Just `require'-ing a file should
LMI> do anything but load the file, in my opinion. If you want to install
LMI> stuff, then you should call the installation function explicitly.
LMI> Otherwise it's just too confusing...
I don't think many people are using spam-stat.el anyway, so changing
this immediately is OK with me. Do you want:
(defun spam-stat-install ()
(interactive)
(when spam-stat-install-hooks
(spam-stat-install-hooks-function)))
or were you thinking deeper surgery?
Ted
next prev parent reply other threads:[~2011-06-01 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 21:09 Lars Magne Ingebrigtsen
2011-06-01 13:09 ` Ted Zlatanov [this message]
2011-06-03 22:08 ` Lars Magne Ingebrigtsen
2011-06-28 14:25 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uzdwvec.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).