Re: Help testing gnus-search fixups

[Eric Abrahamsen <eric@ericabrahamsen.net>]

On 07/25/21 11:17 AM, Alexandr Vityazev wrote:
> On 2021-07-24, 15:16 -0700, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>
>> On 07/23/21 18:52 PM, Alexandr Vityazev wrote:
>>> On 2021-07-23, 08:18 -0700, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>>>
>>>> On 07/23/21 13:12 PM, Alexandr Vityazev wrote:
>>>>> Hi!
>>>>>
>>>>> GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24,
>>>>> cairo version 1.16.0). Gnus v5.13.
>>>>>
>>>>> I tested the new version of gnus-search-indexed-parse-output yesterday
>>>>> and the search with notmuch completely fails. gnus-verbose is set to
>>>>> 10. press GG and type any search query, with the patch, I get:
>>>>>
>>>>>   Doing /home/akagi/.guix-profile/bin/notmuch query on
>>>>>   (nnmaildir+posteo:Drafts nnmaildir+posteo:Inbox nnmaildir+posteo:Sent
>>>>>   nnmaildir+posteo:Trash nnmaildir+posteo:Notes)...
>>>>>   Group nnselect:nnselect-87lf5xus2s.fsf contains no messages
>>>>
>>>> Hi, thanks for the report. Would you mind running your query on the
>>>> command line (using the same syntax as gnus-search does, mostly
>>>> output=files), and sending me the resulting list of file names
>>>> (off-list, if you prefer). I'll try to find out why the parsing process
>>>> is failing.
>>>>
>>>>
>>> notmuch search --output=files test
>>>
>>>
>>>
>>> in *Group* GG with "test" query, I get:
>>>
>>>    Doing /home/akagi/.guix-profile/bin/notmuch query on
>>>    (nnmaildir+posteo:Drafts nnmaildir+posteo:Inbox nnmaildir+posteo:Sent
>>>    nnmaildir+posteo:Trash nnmaildir+posteo:Notes nnmaildir+posteo:Junk)...
>>>    Group nnselect:nnselect-87czr8uasp.fsf contains no messages
>>
>> Hmm, I'm not able to reproduce this: it's a little difficult since I
>> don't actually have the files on my machine, but as far as I can tell
>> the search results are being parsed correctly. Are you familiar with
>> edebug at all? Is there any chance I could get you to step through the
>> function and see where things are going off?
>>
>> Thanks,
>> Eric
>>
>>
> I tested gnus-search-indexed-parse-output with edebug and found where
> something is going on. The attached patch fixes the issue for me.

Wonderful, thank you very much for doing that. That code was added in to
fix a different bug, and I think we're just playing the usual "is the
group prefixed or not" game. I need to more thoroughly test the
primary/secondary select method cases, but at least we know what the
issue is -- thanks again for your debugging!

Eric