Gnus development mailing list
 help / color / mirror / Atom feed
From: Andrew Cohen <cohen@andy.bu.edu>
To: ding@gnus.org
Subject: Re: gnus-completing-read vs XEmacs 21.4
Date: Fri, 08 Oct 2010 08:14:41 -0400	[thread overview]
Message-ID: <877hhsj2z2.fsf@andy.bu.edu> (raw)
In-Reply-To: <87fwwl7sub.fsf@keller.adm.naquadah.org>

>>>>> "Julien" == Julien Danjou <julien@danjou.info> writes:

    Julien> On Mon, Oct 04 2010, Lawrence Mitchell wrote:
    >> That is almost certainly the wrong fix, since it now breaks if
    >> collection is a hash-table or a function.

    Julien> Collection is always a list.

In nnir.el collection is an alist. This fix for old Xemacsen breaks nnir
search querying.

I guess we could do one of

1. revert nnir.el to use completing-read.
2. add a test in gnus-emacs-completing-read to see if collection is an
alist.

Regards,
Andy





  parent reply	other threads:[~2010-10-08 12:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 14:20 Dave Goldberg
2010-10-04 14:32 ` Julien Danjou
2010-10-04 15:20   ` Dave Goldberg
2010-10-04 15:29     ` Julien Danjou
2010-10-04 15:38       ` Dave Goldberg
2010-10-04 16:04         ` Dave Goldberg
2010-10-04 16:08           ` Julien Danjou
2010-10-04 16:25           ` Lawrence Mitchell
2010-10-04 16:31             ` Dave Goldberg
2010-10-04 16:35               ` Lawrence Mitchell
2010-10-04 16:37             ` Julien Danjou
2010-10-04 16:54               ` Lawrence Mitchell
2010-10-04 17:47                 ` Julien Danjou
2010-10-04 18:28                   ` Dave Goldberg
2010-10-04 20:18                     ` Julien Danjou
2010-10-04 21:55                       ` Dave Goldberg
2010-10-08 12:14                   ` Andrew Cohen [this message]
2010-10-08 14:35                     ` Julien Danjou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hhsj2z2.fsf@andy.bu.edu \
    --to=cohen@andy.bu.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).