From: Lawrence Mitchell <wence@gmx.li>
To: ding@gnus.org
Subject: Re: gnus-completing-read vs XEmacs 21.4
Date: Mon, 04 Oct 2010 17:54:39 +0100 [thread overview]
Message-ID: <pvhplj6d3nlc.fsf@gmx.li> (raw)
In-Reply-To: <sa3lj6dewx5.fsf@cigue.easter-eggs.fr>
Julien Danjou wrote:
> On Mon, Oct 04 2010, Lawrence Mitchell wrote:
>> This is almost certainly because old (for some value of old)
>> versions of Emacs and XEmacs expect the second value of
>> try-completion to be an alist and the car of each element is
>> checked for matching.
> Okay, fix pushed. I hate that XEmacs. :-)
That is almost certainly the wrong fix, since it now breaks if
collection is a hash-table or a function. In addition it does
needless work if collection is an obarray. Hence why my
suggested fix special-cased on collection being a list.
Additionally, my misleading lack of comma in the paragraph above
has lead to an incorrect comment.
It should be something more like:
;; Old versions of Emacs (21.4 and below) and XEmacs expect that
;; a listp collection is actually an alist, the cars of whose
;; elements are tested for completion candidates
Lawrence
--
Lawrence Mitchell <wence@gmx.li>
next prev parent reply other threads:[~2010-10-04 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 14:20 Dave Goldberg
2010-10-04 14:32 ` Julien Danjou
2010-10-04 15:20 ` Dave Goldberg
2010-10-04 15:29 ` Julien Danjou
2010-10-04 15:38 ` Dave Goldberg
2010-10-04 16:04 ` Dave Goldberg
2010-10-04 16:08 ` Julien Danjou
2010-10-04 16:25 ` Lawrence Mitchell
2010-10-04 16:31 ` Dave Goldberg
2010-10-04 16:35 ` Lawrence Mitchell
2010-10-04 16:37 ` Julien Danjou
2010-10-04 16:54 ` Lawrence Mitchell [this message]
2010-10-04 17:47 ` Julien Danjou
2010-10-04 18:28 ` Dave Goldberg
2010-10-04 20:18 ` Julien Danjou
2010-10-04 21:55 ` Dave Goldberg
2010-10-08 12:14 ` Andrew Cohen
2010-10-08 14:35 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pvhplj6d3nlc.fsf@gmx.li \
--to=wence@gmx.li \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).