* [PATCH] shr: render <em> as italic, not bold
@ 2012-12-23 12:25 Andreas Schwab
2012-12-23 12:47 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2012-12-23 12:25 UTC (permalink / raw)
To: ding
* shr.el (shr-tag-em): Render as italic, not bold.
---
lisp/shr.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/shr.el b/lisp/shr.el
index 0370455..322c1d5 100644
--- a/lisp/shr.el
+++ b/lisp/shr.el
@@ -894,7 +894,7 @@ ones, in case fg and bg are nil."
(shr-fontize-cont cont 'italic))
(defun shr-tag-em (cont)
- (shr-fontize-cont cont 'bold))
+ (shr-fontize-cont cont 'italic))
(defun shr-tag-strong (cont)
(shr-fontize-cont cont 'bold))
--
1.8.0.2
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shr: render <em> as italic, not bold
2012-12-23 12:25 [PATCH] shr: render <em> as italic, not bold Andreas Schwab
@ 2012-12-23 12:47 ` Ted Zlatanov
2012-12-23 13:08 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Ted Zlatanov @ 2012-12-23 12:47 UTC (permalink / raw)
To: ding
On Sun, 23 Dec 2012 13:25:15 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
AS> * shr.el (shr-tag-em): Render as italic, not bold.
AS> (defun shr-tag-em (cont)
AS> - (shr-fontize-cont cont 'bold))
AS> + (shr-fontize-cont cont 'italic))
Does that look reasonable everywhere? I know at least consoles don't
support 'italic.
Maybe there's a way to know if the visuals support 'italic and use 'bold
otherwise? Or make it customizable?
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shr: render <em> as italic, not bold
2012-12-23 12:47 ` Ted Zlatanov
@ 2012-12-23 13:08 ` Andreas Schwab
2012-12-23 13:50 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2012-12-23 13:08 UTC (permalink / raw)
To: ding
Ted Zlatanov <tzz@lifelogs.com> writes:
> On Sun, 23 Dec 2012 13:25:15 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> AS> * shr.el (shr-tag-em): Render as italic, not bold.
>
> AS> (defun shr-tag-em (cont)
> AS> - (shr-fontize-cont cont 'bold))
> AS> + (shr-fontize-cont cont 'italic))
>
> Does that look reasonable everywhere?
Just like <i>.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shr: render <em> as italic, not bold
2012-12-23 13:08 ` Andreas Schwab
@ 2012-12-23 13:50 ` Ted Zlatanov
2012-12-23 14:20 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Ted Zlatanov @ 2012-12-23 13:50 UTC (permalink / raw)
To: ding
On Sun, 23 Dec 2012 14:08:02 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
AS> Ted Zlatanov <tzz@lifelogs.com> writes:
>> On Sun, 23 Dec 2012 13:25:15 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
AS> * shr.el (shr-tag-em): Render as italic, not bold.
>>
AS> (defun shr-tag-em (cont)
AS> - (shr-fontize-cont cont 'bold))
AS> + (shr-fontize-cont cont 'italic))
>>
>> Does that look reasonable everywhere?
AS> Just like <i>.
w3m and others in a console display <i> differently but not italicized
because the console doesn't normally support that.
Will your change accomplish the same, or will 'italic be lost on a
console? And if the latter, I think we should provide some fallback,
maybe use 'bold if 'italic is not available.
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shr: render <em> as italic, not bold
2012-12-23 13:50 ` Ted Zlatanov
@ 2012-12-23 14:20 ` Andreas Schwab
2012-12-23 15:39 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2012-12-23 14:20 UTC (permalink / raw)
To: ding
Ted Zlatanov <tzz@lifelogs.com> writes:
> Will your change accomplish the same, or will 'italic be lost on a
> console?
Emacs renders the italic face as underline if italic is not supported.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shr: render <em> as italic, not bold
2012-12-23 14:20 ` Andreas Schwab
@ 2012-12-23 15:39 ` Ted Zlatanov
0 siblings, 0 replies; 6+ messages in thread
From: Ted Zlatanov @ 2012-12-23 15:39 UTC (permalink / raw)
To: ding
On Sun, 23 Dec 2012 15:20:45 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
AS> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Will your change accomplish the same, or will 'italic be lost on a
>> console?
AS> Emacs renders the italic face as underline if italic is not supported.
Oh, nice. I didn't know that. I think your patch is fine then. Applied.
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-23 15:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-23 12:25 [PATCH] shr: render <em> as italic, not bold Andreas Schwab
2012-12-23 12:47 ` Ted Zlatanov
2012-12-23 13:08 ` Andreas Schwab
2012-12-23 13:50 ` Ted Zlatanov
2012-12-23 14:20 ` Andreas Schwab
2012-12-23 15:39 ` Ted Zlatanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).