Re: Gnus always loads cl

[Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann)]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> (eval-and-compile
>   (when (= emacs-major-version 20)
>     ;; gethash, hash-table-count, make-hash-table, mapc
>     (require 'cl)
>     (defalias 'puthash 'cl-puthash)))

I'm not so happy with this.  It is better to just check whether the
functions are defined, I think.  Maybe something like this?

(unless (fboundp 'puthash)
  (require 'cl)
  (defalias 'puthash 'cl-puthash))

In principle, it is also bad to do the defalias, but maybe in this
case `puthash' is sufficiently standard so that the defalias is good
anyway.

Hmmm...  But isn't puthash defined as a macro in cl-macs.el or cl.el,
even in Emacs 20?  So I'm surprised that you need the defalias.  Or
maybe only gethash etc are macros, and the macro is missing for
puthash?  In this case, please add a comment saying "alias puthash is
missing from Emacs 20 cl.el" or something like that.

What do you think?

kai
-- 
~/.signature is: umop ap!sdn    (Frank Nobis)