message-tab: grok eudc?

message-tab: grok eudc?

[Kai Grossjohann]

What do people think about this patch to make message-expand-name
support EUDC?

--- message.el.~7.2.~	Mon Jan  5 17:30:15 2004
+++ message.el	Thu Jan  8 10:06:27 2004
@@ -6628,9 +6628,12 @@
 	    (delete-region (point) (progn (forward-line 3) (point))))))))))
 
 (defun message-expand-name ()
-  (if (fboundp 'bbdb-complete-name)
-      (bbdb-complete-name)
-    (expand-abbrev)))
+  (cond ((and (boundp 'eudc-protocol) eudc-protocol)
+	 (eudc-expand-inline))
+	((fboundp 'bbdb-complete-name)
+	 (bbdb-complete-name))
+	(t
+	 (expand-abbrev))))
 
 ;;; Help stuff.

Re: message-tab: grok eudc?

[David S Goldberg]

I just added eudc-expand-inline to message-completion-alist.  Been
working like a champ since I did the equivalent with message-x :-)

(setq message-completion-alist
      (list
       (cons "^\\(Newsgroups\\|Followup-To\\|Posted-To\\|Gcc\\):"
	     'message-expand-group)
       (cons "^\\(Resent-\\)?\\(From\\|To\\|B?Cc\\):"
	     '(lambda ()
		(interactive)
		(condition-case nil
		    (eudc-expand-inline)
		  (error nil))
		(dsg-eudc-fill-header)))))

However, if message-expand-name can do it all automatically, so much
the better.
-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: message-tab: grok eudc?

[Reiner Steib]

On Thu, Jan 08 2004, Kai Grossjohann wrote:

> What do people think about this patch to make message-expand-name
> support EUDC?

I had now idea what this is until I asked Emacs about
`eudc-expand-inline'.  :-)
(FWIW, I see no problem in installing it in No Gnus.)

>  (defun message-expand-name ()
> -  (if (fboundp 'bbdb-complete-name)
> -      (bbdb-complete-name)
> -    (expand-abbrev)))
> +  (cond ((and (boundp 'eudc-protocol) eudc-protocol)
                 (gnus-boundp 'eudc-protocol) ?

... ah, no, we shouldn't use `gnus-boundp' in `message.el'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: message-tab: grok eudc?

[Kai Grossjohann]

Committed.

Kai