Left-clicking on a link in an shr-rendered HTML article opens the link twice

Left-clicking on a link in an shr-rendered HTML article opens the link twice

[Adam Sjøgren]

Am I the only one with this problem: If I open an HTML article in Gnus,
rendered by shr, and left-click a link, almost all the time, the link is
opened twice in my [external] browser?

What seems to happen is that first widget-button-click fires, and calls
browse-url which opens the link in my browser, and then shr-browse-url
fires, which also calls browse-url and opens the link in my browser a
second time.

Middle-clicking on the link only opens it once, but it's kind of
annoying to have to remember to middle-click.

I tried fixing it with:

  (define-key shr-map (kbd "[mouse-2]") nil)

but that was too wild a guess. Now I have this instead, which works:

  (setq shr-map
    (let ((map (make-sparse-keymap)))
      (define-key map "a" 'shr-show-alt-text)
      (define-key map "i" 'shr-browse-image)
      (define-key map "z" 'shr-zoom-image)
      (define-key map [?\t] 'shr-next-link)
      (define-key map [?\M-\t] 'shr-previous-link)
      (define-key map [follow-link] 'mouse-face)
      ; (define-key map [mouse-2] 'shr-browse-url)
      (define-key map "I" 'shr-insert-image)
      (define-key map "w" 'shr-copy-url)
      (define-key map "u" 'shr-copy-url)
      (define-key map "v" 'shr-browse-url)
      (define-key map "O" 'shr-save-contents)
      (define-key map "\r" 'shr-browse-url)
      map))

... but it seems kind of wrong?


  Best regards,

    Adam

-- 
 "I need someone to throw blue sky at me"                     Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Left-clicking on a link in an shr-rendered HTML article opens the link twice

[Mike Kupfer]

Adam Sjøgren wrote:

> Am I the only one with this problem: If I open an HTML article in Gnus,
> rendered by shr, and left-click a link, almost all the time, the link is
> opened twice in my [external] browser?

I was seeing this about a year ago, but not since #22157 was closed.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22157

mike

Re: Left-clicking on a link in an shr-rendered HTML article opens the link twice

[Adam Sjøgren]

Mike writes:

> Adam Sjøgren wrote:
>
>> Am I the only one with this problem: If I open an HTML article in Gnus,
>> rendered by shr, and left-click a link, almost all the time, the link is
>> opened twice in my [external] browser?
>
> I was seeing this about a year ago, but not since #22157 was closed.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22157

It's still broken for me in GNU Emacs built from master updated
yesterday (236648fe2623a10c8ca02637b79cd0ceffd0b6b9).

I have to admit I don't understand most of the discussion in the bug.


  Best regards,

    Adam

-- 
 "I need someone to throw blue sky at me"                     Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Left-clicking on a link in an shr-rendered HTML article opens the link twice

[Katsumi Yamaoka]

On Thu, 16 Feb 2017 18:54:03 +0100, Adam Sjøgren wrote:
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22157

> It's still broken for me in GNU Emacs built from master updated
> yesterday (236648fe2623a10c8ca02637b79cd0ceffd0b6b9).

> I have to admit I don't understand most of the discussion in the bug.

Sorry for the confusion.  But I couldn't reproduce it in master.
Are you sure you really use Gnus bundled with Emacs master?
You seem to use:

User-Agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/26.0.50 (gnu/linux)

Re: Left-clicking on a link in an shr-rendered HTML article opens the link twice

[Adam Sjøgren]

Katsumi writes:

> On Thu, 16 Feb 2017 18:54:03 +0100, Adam Sjøgren wrote:
>
>> It's still broken for me in GNU Emacs built from master updated
>> yesterday (236648fe2623a10c8ca02637b79cd0ceffd0b6b9).
>
>> I have to admit I don't understand most of the discussion in the bug.
>
> Sorry for the confusion.  But I couldn't reproduce it in master.

Don't be, the level of discussion there was simply above my head.

And it gets worse:

> Are you sure you really use Gnus bundled with Emacs master?
> You seem to use:
>
> User-Agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/26.0.50 (gnu/linux)

I was _so_ sure I was. But you are absolutely right, I wasn't.

Now I am, and it works perfectly.

Sorry for my confusion!

(And thanks for fixing the problem way back when.)


  Best regards,

    Adam

-- 
 "Angels can fly because they take themselves lightly."       Adam Sjøgren
                                                         asjo@koldfront.dk