gnus-dired-attach, optionally type?

gnus-dired-attach, optionally type?

[Uwe Brauer]

Hi 

 mml-dired-attach is rather rigid, since it does not allow to chose the
 attchment type. I propose to add this functionality, at least
 optionally.

I looked into the code and a modification looks complicated, could
somebody more familiar with the code try it?


thanks

Uwe Brauer 

Re: gnus-dired-attach, optionally type?

[Eric S Fraga]

Uwe Brauer <oub@mat.ucm.es> writes:

> Hi 
>
>  mml-dired-attach is rather rigid, since it does not allow to chose the
>  attchment type. I propose to add this functionality, at least
>  optionally.

I must admit that I have never found a need for this
functionality.  Either I add the type (if new) to mime.types or I simply
edit the message buffer as the attachment information is just text...

-- 
: Eric S Fraga, GnuPG: 0xFFFCF67D
: in Emacs 24.3.50.1 + Ma Gnus v0.8 + evil 1.0-dev
: BBDB version 3.02 ($Date: 2013/05/15 13:17:58 $)

Re: gnus-dired-attach, optionally type?

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

>> "Eric" == Eric S Fraga <Eric> writes:

   > Uwe Brauer <oub@mat.ucm.es> writes:
   >> Hi 
   >> 
   >> mml-dired-attach is rather rigid, since it does not allow to chose the
   >> attchment type. I propose to add this functionality, at least
   >> optionally.

   > I must admit that I have never found a need for this
   > functionality.  Either I add the type (if new) to mime.types or I simply
   > edit the message buffer as the attachment information is just text...

Hm..
Suppose you want to attach say 10 files, which are of the "wrong type",
application/octet-stream instead of 
then you are suggesting a simple query replace!?

The  Problem which this approach  is that I don't know
by heart the correct type, for example is it plain/text or text/plain??

While if I use mml-attach-file, present you a list of options. I presume
the next step is you propose a simple function which covers the most
useful changes?

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5556 bytes --]

Re: gnus-dired-attach, optionally type?

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

>> "Eric" == Eric S Fraga <Eric> writes:

   > Uwe Brauer <oub@mat.ucm.es> writes:
   >> Hi 
   >> 
   >> mml-dired-attach is rather rigid, since it does not allow to chose the
   >> attchment type. I propose to add this functionality, at least
   >> optionally.

   > I must admit that I have never found a need for this
   > functionality.  Either I add the type (if new) to mime.types or I simply
   > edit the message buffer as the attachment information is just text...
When I change in gnus-dired-attach

	(mml-attach-file (car files-to-attach)
			 (or (mm-default-file-encoding (car files-to-attach))
			     "application/octet-stream") nil)

To 

	(mml-attach-file (car files-to-attach)
			     (mml-minibuffer-read-type (car files-to-attach)) )

Then it works as I expect, however the interactive call of that function
is too complicated for me, usually I would do a

(defun my-dired-attach (&optional arg)
  (interactive "P")
   (if arg
   (New code)
   (old code)))

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5556 bytes --]

Re: gnus-dired-attach, optionally type?

[Dave Goldberg]

> [...]
> Then it works as I expect, however the interactive call of that function
> is too complicated for me, usually I would do a

> (defun my-dired-attach (&optional arg)
>   (interactive "P")
>    (if arg
>    (New code)
>    (old code)))

It looks like you are writing a modified version of gnus-dired-attach, along with the above wrapper.  If that's correct then I think this will work.  I haven't tested with this specific case, but it's worked for others:

(defun my-dired-attach (&optional arg)
  (interactive "P")
  (if arg
      (call-interactively 'modified-gnus-dired-attach)
    (call-interactively 'gnus-dired-attach)))

I think you can do something similar with defadvice but I haven't used that.

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: gnus-dired-attach, optionally type?

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

>> "Dave" == Dave Goldberg <david.goldberg6@verizon.net> writes:

   >> (defun my-dired-attach (&optional arg)
   >> (interactive "P")
   >> (if arg
   >> (New code)
   >> (old code)))

   > It looks like you are writing a modified version of
   > gnus-dired-attach, along with the above wrapper.  If that's correct
   > then I think this will work.  I haven't tested with this specific
   > case, but it's worked for others:

   > (defun my-dired-attach (&optional arg)
   >   (interactive "P")
   >   (if arg
   >       (call-interactively 'modified-gnus-dired-attach)
   >     (call-interactively 'gnus-dired-attach)))

Right precisely, I tried that but without the call-interactively.

I originally thought to modify *directly* gnus-dired-attach,[1] but as I
said its interactive structure is too complex for me. Also it seems that
most users don't think such a patch is necessary.


   > I think you can do something similar with defadvice but I haven't
   > used that.

I have decided to avoid defadvice if possible, it is just almost
impossible to debug.

thanks

Uwe 

Footnotes:
[1]  one function to rule them all.


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5556 bytes --]