" (was: " hardcoded in message-change-subject (patch)

" (was: " hardcoded in message-change-subject (patch)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]

I've noted, ``was:'', inserted by message-change-subject, is lowercase.
I think, it would be nicer to have it capitalized (as ``Re:''), but I'm
not sure, everyone would agree with it (opinions, anyone?).

Attached is the patch for making "was: " go in a variable to make
everyone happy.

---Vas

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: message.el.patch --]
[-- Type: text/x-patch, Size: 647 bytes --]

--- message.el~	Thu Jan 23 01:16:00 2003
+++ message.el	Wed Jan 29 20:05:11 2003
@@ -302,6 +302,13 @@
   :group 'message-various
   :type 'regexp)
 
+(defcustom message-change-subject-prefix
+  "was: "
+  "*String to be inserted by message-change-subject in parenthesis
+before the old subject."
+  :group 'message-various
+  :type 'string)
+
 ;;; marking inserted text
 
 ;;;###autoload
@@ -1630,7 +1637,8 @@
 		    (message-delete-line)
 		    (insert (concat "Subject: "
 				    new-subject
-				    " (was: "
+				    " ("
+				    message-change-subject-prefix
 				    old-subject ")\n")))))))))
 
 ;;;###autoload

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: " (was: " hardcoded in message-change-subject (patch)

[Simon Josefsson]

deskpot@myrealbox.com (Vasily Korytov) writes:

> I've noted, ``was:'', inserted by message-change-subject, is lowercase.
> I think, it would be nicer to have it capitalized (as ``Re:''), but I'm
> not sure, everyone would agree with it (opinions, anyone?).

FWIW, the usefor draft uses lower case "was:":

,----
|    In the following examples, please note that only "Re: " is mandated
|    by this standard. "was: " is a convention used by many English-
|    speaking posters to signal a change in subject matter.  Software can
|    always recognize such changes from the References-header.
| 
|       Subject: Film at 11
|       Subject: Re: Film at 11
|       Subject: Godwin's law considered harmful (was: Film at 11)
|       Subject: Godwin's law (was: Film at 11)
|       Subject: Re: Godwin's law (was: Film at 11)
|       Subject: Re: Godwin's law
`----

I could not find a more canonical specification of it.

> Attached is the patch for making "was: " go in a variable to make
> everyone happy.

If it is added, IMHO it should not be advertised much or include a
prominent warning in the docstring that changing it from the default
can cause irritation.  Compare the bad behaviour caused by some MUAs
that translate Re: etc.

Re: " (was: " hardcoded in message-change-subject (patch)

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

>>>>> "SJ" == Simon Josefsson writes:

 SJ> I could not find a more canonical specification of it.

Me too. Otherwise, I, probably, wouldn't want to change it.

 SJ> If it is added, IMHO it should not be advertised much or include a
 SJ> prominent warning in the docstring that changing it from the default
 SJ> can cause irritation.  Compare the bad behaviour caused by some MUAs
 SJ> that translate Re: etc.

Agreed.

---Vas

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: "

[Lars Magne Ingebrigtsen]

deskpot@myrealbox.com (Vasily Korytov) writes:

> I've noted, ``was:'', inserted by message-change-subject, is lowercase.
> I think, it would be nicer to have it capitalized (as ``Re:''), but I'm
> not sure, everyone would agree with it (opinions, anyone?).

I don't think that string should be customizable.  Like with "Re:",
it's really a protocol-specific string.  And since USEFOR uses
"(was:", Gnus should, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen