Re: Command for browsing article URLs?

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> Hi Eric,
>
> I tried your gnus-article-browse-url and I get the following error:
>
> sort: Wrong type argument: stringp, ((#<marker at 627 in *Article
> nntp+news.gwene.org:gmane.linux.debian.user*> . #<marker at 927 in
> *Article nntp+news.gwene.org:gmane.linux.debian.user*>) #<marker at 623
> in *Article nntp+news.gwene.org:gmane.linux.debian.user*>)
>
> Not tried any serious debugging yet as I'm busy with work.  In any case,
> the only reason for sort to complain, that I can see, is that somehow
> ivy (which I use) is confused, given that you use completing-read.  Any
> suggestions welcome.

Thanks, that was helpful! When you have a moment, please try this
updated version.

I'm thinking it might be better named "gnus-article-click-button", since
that's pretty much what it does now.

#+begin_src elisp
(defun gnus-article-browse-url (arg)
"Scan the current article body for links, and offer to browse them.
With prefix ARG, also collect links from message headers.

Links are opened using `widget-button-press'. If only one link
is found, browse that directly, otherwise use completion to
select a link."
  (interactive "P")
  (let ((opened (and (gnus-buffer-live-p gnus-article-buffer)
		     (get-buffer-window gnus-article-buffer t)
		     ;; We might have opened an article, but then moved to
		     ;; a different summary line.
		     (= gnus-current-article (gnus-summary-article-number))))
	pt urls target)
    (unless opened
      (gnus-summary-select-article)
      (gnus-configure-windows 'article))
    (gnus-with-article-buffer
      (if arg
	  (goto-char (point-min))
	(article-goto-body)
	;; Back up a char, in case body starts with a widget.
	(backward-char))
      (setq pt (point))
      (while (progn (widget-forward 1)
		    (> (point) pt))
	(setq pt (point))
	(when-let ((u (cond
		       ((get-text-property (point) 'shr-url))
		       ((get-text-property (point) 'gnus-string))
		       ((let ((dat (get-text-property (point) 'gnus-data)))
			  (pcase dat
			    ('nil nil)
			    ((and (pred (stringp) (pred (string= ">"))))
			     (buffer-substring (line-beginning-position) (line-end-position)))
			    ;; Does a marker always signify the
			    ;; signature?  We may never know.
			    ((pred (markerp))
			     "<signature>")
			    ;; There are more weird cases, add as
			    ;; necessary.
			    (_ dat)))))))
	  (push (cons u pt) urls)))
      (setq target
	    (assoc (cond ((= (length urls) 1)
			  (caar urls))
			 ((> (length urls) 1)
			  (completing-read "URL to browse: "
					   (delete-dups urls) nil t)))
		   urls))
      (if target
	  (funcall-interactively #'widget-button-press (1+ (cdr target)))
	(message "No URLs found.")))
    ;; Now what?  If we're not in the *Summary* buffer anymore (i.e.,
    ;; pressing the button created a new buffer), do nothing.
    ;; Otherwise, if the article wasn't opened to begin with, close it
    ;; after we follow the link.
    (when (get-buffer-window gnus-summary-buffer)
      (gnus-summary-expand-window opened))))

(with-eval-after-load "gnus-sum"
  (define-key gnus-summary-mime-map (kbd "l") #'gnus-article-browse-url))
#+end_src