Re: Command for browsing article URLs?

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>
>> On Friday, 18 Jan 2019 at 10:04, Eric Abrahamsen wrote:
>>> I'll filter those out in advance, but would also like to know what was
>>> producing that particular gnus-data. What message were you on when you
>>> got that error? I.e., the offending data was:
>>
>> These were the active places (i.e. where I can TAB to and do something
>> on) in an email that includes previous messages, things highlighted by
>> gnus especially when using the mechanisms in gnus for hiding part of a
>> citation.  The particular message was the previous one you had posted to
>> this group (mailing list but I'm reading it via gwene/gmane).
>
> Well that's weird, when I use the command on that message, it offers me
> the "Eric Abrahamsen wrote:" text as a link I can click, and toggles
> visibility of the quote as you'd expect. I'll try to figure this out.

Nope, wasn't able to figure it out. I can't find any messages that
return that kind of marker structure for me.

Here's one more version that might handle that case properly for you,
and at the very least shouldn't error.


(defun gnus-article-browse-url (arg)
  "Scan the current article body for links, and offer to browse them.
With prefix ARG, also collect links from message headers.

Links are opened using `widget-button-press'.  If only one link
is found, browse that directly, otherwise use completion to
select a link."
  (interactive "P")
  (let ((opened (and (gnus-buffer-live-p gnus-article-buffer)
		     (get-buffer-window gnus-article-buffer t)
		     ;; We might have opened an article, but then moved to
		     ;; a different summary line.
		     (= gnus-current-article (gnus-summary-article-number))))
	pt urls target)
    (unless opened
      (gnus-summary-select-article)
      (gnus-configure-windows 'article))
    (gnus-with-article-buffer
      (if arg
	  (goto-char (point-min))
	(article-goto-body)
	;; Back up a char, in case body starts with a widget.
	(backward-char))
      (setq pt (point))
      (while (progn (widget-forward 1)
		    (> (point) pt))
	(setq pt (point))
	(when-let ((u (cond
		       ((get-text-property (point) 'shr-url))
		       ((get-text-property (point) 'gnus-string))
		       ((let ((dat (get-text-property (point) 'gnus-data)))
			  (pcase dat
			    ('nil nil)
			    ((and (pred stringp) (pred (string-match-p "^>")))
			     ;; This is a "so-and-so wrote:" quote.
			     (buffer-substring-no-properties
			      (line-beginning-position) (line-end-position)))
			    ;; Does a marker always signify the
			    ;; signature?  We may never know.
			    ((pred markerp)
			     "<signature>")
			    ;; What is this, exactly?
			    (`(((,(and (pred markerp) start) .
				 ,(and (pred markerp) end))) _)
			     (buffer-substring-no-properties start end))
			    ;; There are more weird cases, add as
			    ;; necessary.
			    ((pred stringp) dat)))))))
	  (push (cons u pt) urls)))
      (setq target
	    (assoc (cond ((= (length urls) 1)
			  (caar urls))
			 ((> (length urls) 1)
			  (completing-read "URL to browse: "
					   (setq urls (nreverse (delete-dups urls)))
					   nil t)))
		   urls))
      (if target
	  (funcall-interactively #'widget-button-press (1+ (cdr target)))
	(message "No URLs found.")))
    ;; Now what?  If we're not in the *Summary* buffer anymore (i.e.,
    ;; pressing the button created a new buffer), do nothing.
    ;; Otherwise, if the article wasn't opened to begin with, close it
    ;; after we follow the link.
    (when (get-buffer-window gnus-summary-buffer)
      (gnus-summary-expand-window opened))))