auth-sources default

auth-sources default

[Michael Piotrowski]

Hi,

At least for me, the default setting of `auth-sources'--or any other
setting where `auth-sources' just contains strings--doesn't seem to work
in the new version of auth-sources.el.  The problem seems to be in
`auth-source-backend-parse': `auth-source-backend-parse-parameters' is
called with the original entry (i.e., a plain string) in any case, and
then `plist-get' fails.

As a workaround one can set `auth-sources' to a plist, but I guess it
would be good if the default worked ;-)

Best regards

-- 
Dr.-Ing. Michael Piotrowski, M.A.                   <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt> (ID 0x1614A044)

Re: auth-sources default

[Ted Zlatanov]

On Sat, 12 Feb 2011 15:52:09 -0500 Michael Piotrowski <mxp@dynalabs.de> wrote: 

MP> At least for me, the default setting of `auth-sources'--or any other
MP> setting where `auth-sources' just contains strings--doesn't seem to work
MP> in the new version of auth-sources.el.  The problem seems to be in
MP> `auth-source-backend-parse': `auth-source-backend-parse-parameters' is
MP> called with the original entry (i.e., a plain string) in any case, and
MP> then `plist-get' fails.

MP> As a workaround one can set `auth-sources' to a plist, but I guess it
MP> would be good if the default worked ;-)

I'm not sure what you're seeing but it works for me:

(auth-source-backend-parse "test")

=> [object auth-source-backend "test" netrc "test" t t t auth-source-netrc-create auth-source-netrc-search]

Try to run this:

(mapcar 'auth-source-backend-parse auth-sources)

and check the output.  It should be a list of backend instances like
above.

Maybe you still have an old .elc file?  Or you're using Emacs'
auth-source.el, which hasn't been updated yet?

Ted

Re: auth-sources default

[Michael Piotrowski]

On 2011-02-12, Ted Zlatanov <tzz@lifelogs.com> wrote:

>> At least for me, the default setting of `auth-sources'--or any other
>> setting where `auth-sources' just contains strings--doesn't seem to work
>> in the new version of auth-sources.el.  The problem seems to be in
>> `auth-source-backend-parse': `auth-source-backend-parse-parameters' is
>> called with the original entry (i.e., a plain string) in any case, and
>> then `plist-get' fails.
>
>> As a workaround one can set `auth-sources' to a plist, but I guess it
>> would be good if the default worked ;-)
>
> I'm not sure what you're seeing but it works for me:
>
> (auth-source-backend-parse "test")
>
> => [object auth-source-backend "test" netrc "test" t t t
> auth-source-netrc-create auth-source-netrc-search]

Well, I get

  Malformed property list: "test", "test"

> Try to run this:
>
> (mapcar 'auth-source-backend-parse auth-sources)
>
> and check the output.  It should be a list of backend instances like
> above.

Unfortunately not.  It works when `auth-sources' is a plist such as

  (:source "~/.authinfo" :host t :protocol t)

but not when it's a list of strings.

I inserted

  (message "%S // %S" entry backend)

at the start of `auth-source-backend-parse-parameters'.  When evaluating
(auth-source-backend-parse "test"), I get the following output:

  "test" // [object auth-source-backend "test" netrc "test" t t t auth-source-netrc-create auth-source-netrc-search]
  (:source "test") // [object auth-source-backend "test" netrc "test" t t t auth-source-netrc-create auth-source-netrc-search]

> Maybe you still have an old .elc file?  Or you're using Emacs'
> auth-source.el, which hasn't been updated yet?

No, I checked this.  I'm using XEmacs 21.4.22; according to the
documentation, GNU Emacs' `plist-get' "accepts a malformed plist
argument".  This is not the case in XEmacs--maybe that's the problem?

Greetings

-- 
Dr.-Ing. Michael Piotrowski, M.A.                   <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt> (ID 0x1614A044)

Re: auth-sources default

[Ted Zlatanov]

On Sat, 12 Feb 2011 17:19:30 -0500 Michael Piotrowski <mxp@dynalabs.de> wrote: 

MP> No, I checked this.  I'm using XEmacs 21.4.22; according to the
MP> documentation, GNU Emacs' `plist-get' "accepts a malformed plist
MP> argument".  This is not the case in XEmacs--maybe that's the problem?

Yeah.  I can't fix it for a while but if someone with XEmacs access
wants to take a shot at it, go ahead.  Sorry for the trouble.

Ted

Re: auth-sources default

[Ted Zlatanov]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Sat, 12 Feb 2011 17:07:30 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Sat, 12 Feb 2011 17:19:30 -0500 Michael Piotrowski <mxp@dynalabs.de> wrote: 
MP> No, I checked this.  I'm using XEmacs 21.4.22; according to the
MP> documentation, GNU Emacs' `plist-get' "accepts a malformed plist
MP> argument".  This is not the case in XEmacs--maybe that's the problem?

TZ> Yeah.  I can't fix it for a while but if someone with XEmacs access
TZ> wants to take a shot at it, go ahead.  Sorry for the trouble.

Try out the attached patch and let me know if it works for you.  If so I
will commit it (it's harmless otherwise).

Thanks
Ted


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: auth-plist-xemacs.patch --]
[-- Type: text/x-diff, Size: 634 bytes --]

diff --git a/lisp/auth-source.el b/lisp/auth-source.el
index b7a7b41..d0ca4a2 100644
--- a/lisp/auth-source.el
+++ b/lisp/auth-source.el
@@ -333,7 +333,10 @@ If the value is not a list, symmetric encryption will be used."
 Using the plist ENTRY, get the :host, :protocol, and :user search
 parameters.  Accepts :port as an alias to :protocol.  Sets all
 the parameters to t if they are missing."
-  (let (val)
+  (let ((entry (if (stringp entry)
+                   nil
+                 entry))
+        val)
     (when (setq val (plist-get entry :host))
       (oset backend host val))
     (when (setq val (plist-get entry :user))

Re: auth-sources default

[Ted Zlatanov]

On Sun, 13 Feb 2011 08:07:49 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Sat, 12 Feb 2011 17:07:30 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 
TZ> On Sat, 12 Feb 2011 17:19:30 -0500 Michael Piotrowski <mxp@dynalabs.de> wrote: 
MP> No, I checked this.  I'm using XEmacs 21.4.22; according to the
MP> documentation, GNU Emacs' `plist-get' "accepts a malformed plist
MP> argument".  This is not the case in XEmacs--maybe that's the problem?

TZ> Yeah.  I can't fix it for a while but if someone with XEmacs access
TZ> wants to take a shot at it, go ahead.  Sorry for the trouble.

TZ> Try out the attached patch and let me know if it works for you.  If so I
TZ> will commit it (it's harmless otherwise).

I committed that patch.  I'd appreciate some feedback to tell me if it
helped.

Ted

Re: auth-sources default

[Michael Piotrowski]

On 2011-02-14, Ted Zlatanov <tzz@lifelogs.com> wrote:

>> No, I checked this.  I'm using XEmacs 21.4.22; according to the
>> documentation, GNU Emacs' `plist-get' "accepts a malformed plist
>> argument".  This is not the case in XEmacs--maybe that's the problem?
>
>> Yeah.  I can't fix it for a while but if someone with XEmacs access
>> wants to take a shot at it, go ahead.  Sorry for the trouble.
>
>> Try out the attached patch and let me know if it works for you.  If so I
>> will commit it (it's harmless otherwise).
>
> I committed that patch.  I'd appreciate some feedback to tell me if it
> helped.

I'm currently in the U.S., therefore my delay in answering.  Yup, it
seems to work nicely now.  Thank you for the quick fix!

Best regards

-- 
Dr.-Ing. Michael Piotrowski, M.A.                   <mxp@dynalabs.de>
Public key at <http://www.dynalabs.de/mxp/pubkey.txt> (ID 0x1614A044)

Re: auth-sources default

[Ted Zlatanov]

On Mon, 14 Feb 2011 13:46:20 -0500 Michael Piotrowski <mxp@dynalabs.de> wrote: 

MP> On 2011-02-14, Ted Zlatanov <tzz@lifelogs.com> wrote:
>> I committed that patch.  I'd appreciate some feedback to tell me if it
>> helped.

MP> I'm currently in the U.S., therefore my delay in answering.  Yup, it
MP> seems to work nicely now.  Thank you for the quick fix!

No worries, I was talking to the XEmacs Gnus users in general.  Thanks
for confirming it worked.

Ted