Pushing to the Gnus repository

Pushing to the Gnus repository

[Adam Sjøgren]

  Hi,

I just pushed 3 small commits to the Gnus repository, and got this
output:

  $ git push
  Counting objects: 15, done.
  Delta compression using up to 4 threads.
  Compressing objects: 100% (15/15), done.
  Writing objects: 100% (15/15), 2.02 KiB | 0 bytes/s, done.
  Total 15 (delta 12), reused 0 (delta 0)
  remote: hooks/post-receive: 215: export: Sjøgren: bad variable name
  To https://git.gnus.org/gnus.git
     3af70ac..cb38ce9  master -> master
  $ 

What is the post-receive hook trying to do with my lastname; does it
matter?


  Best regards,

    Adam

-- 
 "Never spend more than a year on anything."                  Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Pushing to the Gnus repository

[Katsumi Yamaoka]

On Sat, 07 Mar 2015 22:59:23 +0100, Adam Sjøgren wrote:
> I just pushed 3 small commits to the Gnus repository, and got this
> output:
>   $ git push
[...]
>   remote: hooks/post-receive: 215: export: Sjøgren: bad variable name
[...]
> What is the post-receive hook trying to do with my lastname; does it
> matter?

I guess it is an error message issued by a script that sends
a mail to the ding-commits list (gmane.emacs.gnus.cvs).  I don't
know how it failed, but it must be the cause of having not been
mailed of your recent commits, I think (non-ASCII letter?).

Re: Pushing to the Gnus repository

[Adam Sjøgren]

Katsumi writes:

> I guess it is an error message issued by a script that sends
> a mail to the ding-commits list (gmane.emacs.gnus.cvs).

Yes, it seems so.

> I don't know how it failed, but it must be the cause of having not
> been mailed of your recent commits, I think (non-ASCII letter?).

I'm not changing my name, it has kind of grown on me, so I hope the
script can be fixed somehow.

2015, and still non-ascii chars are giving us pain...


  Best regards,

    Adam

-- 
 "The soap bubble experiment reveals something                Adam Sjøgren
  fundamental about the universe: it is lazy."           asjo@koldfront.dk

Re: Pushing to the Gnus repository

[Andreas Schwab]

Does that help?  Unlike all other shells, dash doesn't treat the
arguments of the export builtin as assignments where word splitting is
suppressed.

Andreas.

------------------------------>8--------------------------------------
From 3a2113bfe8c44f435e5aef650cbe52a0516a0401 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <schwab@linux-m68k.org>
Date: Tue, 10 Mar 2015 23:12:29 +0100
Subject: [PATCH] Fix missing quotes in post-receive script

	* post-receive (generate_email_header): Add quotes around values in
	export.
---
 etc/post-receive | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/post-receive b/etc/post-receive
index db59bd1..676b885 100755
--- a/etc/post-receive
+++ b/etc/post-receive
@@ -211,8 +211,8 @@ generate_email_header()
 {
 
         # Use the email address of the author of the last commit.
-        export USER_EMAIL=$(git log -1 $short_refname --format=format:%ce HEAD)
-        export USER_NAME=$(git log -1 $short_refname --format=format:%cn HEAD)
+        export USER_EMAIL="$(git log -1 $short_refname --format=format:%ce HEAD)"
+        export USER_NAME="$(git log -1 $short_refname --format=format:%cn HEAD)"
 
 	# --- Email (all stdout will be the email)
 	# Generate header
-- 
2.3.2


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Pushing to the Gnus repository

[Adam Sjøgren]

Andreas writes:

> Does that help?  Unlike all other shells, dash doesn't treat the
> arguments of the export builtin as assignments where word splitting is
> suppressed.

It did not seem to help; I just pushed two commits, and the output was
this:

  asjo@topper:~/elisp/gnus$ git push
  Counting objects: 9, done.
  Delta compression using up to 4 threads.
  Compressing objects: 100% (9/9), done.
  Writing objects: 100% (9/9), 1.06 KiB | 0 bytes/s, done.
  Total 9 (delta 7), reused 0 (delta 0)
  remote: hooks/post-receive: 215: export: Sjøgren: bad variable name
  To https://git.gnus.org/gnus.git
     710c9fe..3b51bb0  master -> master
  asjo@topper:~/elisp/gnus$ 


  Best regards,

    Adam

-- 
 "What looks large from a distance                            Adam Sjøgren
  Close up is never that big"                            asjo@koldfront.dk

Re: Pushing to the Gnus repository

[Andreas Schwab]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Andreas writes:
>
>> Does that help?  Unlike all other shells, dash doesn't treat the
>> arguments of the export builtin as assignments where word splitting is
>> suppressed.
>
> It did not seem to help;

Are you sure the change has been installed?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Pushing to the Gnus repository

[Adam Sjøgren]

Andreas writes:

> asjo@koldfront.dk (Adam Sjøgren) writes:

>> It did not seem to help;

> Are you sure the change has been installed?

No, I assumed that was what you did?

I did not realise that /etc/post-receive was in the Gnus repository. I
will push your patch shortly.


  Best regards,

   Adam

-- 
 "No more than that, but very powerful all the same;          Adam Sjøgren
  simple things are good."                               asjo@koldfront.dk

Re: Pushing to the Gnus repository

[Andreas Schwab]

asjo@koldfront.dk (Adam Sjøgren) writes:

> I will push your patch shortly.

The file also needs to be copied into the hooks directory of the
repository on the server.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Pushing to the Gnus repository

[Adam Sjøgren]

Andreas writes:

> asjo@koldfront.dk (Adam Sjøgren) writes:

>> I will push your patch shortly.

> The file also needs to be copied into the hooks directory of the
> repository on the server.

It isn't just symlinked in there somehow?

Anyway, hopefully somebody will do that. Thanks for the patch!


  Best regards,

    Adam

-- 
 "you will enjoy the video."                                  Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Pushing to the Gnus repository

[Andreas Schwab]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Andreas writes:
>
>> asjo@koldfront.dk (Adam Sjøgren) writes:
>
>>> I will push your patch shortly.
>
>> The file also needs to be copied into the hooks directory of the
>> repository on the server.
>
> It isn't just symlinked in there somehow?

There is nothing to symlink to.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Pushing to the Gnus repository

[Adam Sjøgren]

Andreas writes:

> There is nothing to symlink to.

I like your cryptic answers. They are funny. Unhelpful, but funny.

I didn't set it up, and I don't have access, so all I can do is
speculate, based on what I would have done, if I had.


  Best regards,

    Adam

-- 
 "perhaps he does not understand that business needs          Adam Sjøgren
  to be run without idiot balloons or child games."      asjo@koldfront.dk

Re: Pushing to the Gnus repository

[Ted Zlatanov]

On Sat, 28 Mar 2015 22:06:16 +0100 asjo@koldfront.dk (Adam Sjøgren) wrote: 

AS> Andreas writes:
>> There is nothing to symlink to.

AS> I like your cryptic answers. They are funny. Unhelpful, but funny.

AS> I didn't set it up, and I don't have access, so all I can do is
AS> speculate, based on what I would have done, if I had.

I have access and put the updated hook in place.  Sorry for the delay.

Ted