Gnus development mailing list
 help / color / mirror / Atom feed
* Delayed sending by time
@ 2011-02-13 18:27 Adam Sjøgren
  2011-02-13 19:13 ` [PATCH] Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
  0 siblings, 1 reply; 8+ messages in thread
From: Adam Sjøgren @ 2011-02-13 18:27 UTC (permalink / raw)
  To: ding

The documentation of C-c C-j in a message buffer says:

| * hh:mm for a specific time.  Use 24h format.  If it is later than this
|   time, then the deadline is tomorrow, else today.

yet, if I enter "08:00" the email gets written to drafts/delayed and
then sent immediately. Time here is currently 19:26.

If I enter 2011-02-14 08:00, the email stays in the delayed queue as
expected.

I think writing just a time used to work...


  Best regards,

    Adam

-- 
 "I went for the fireengines                                  Adam Sjøgren
  But they were all upside down"                         asjo@koldfront.dk




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] Make gnus-delay-article work for HH:MM on the next day.
  2011-02-13 18:27 Delayed sending by time Adam Sjøgren
@ 2011-02-13 19:13 ` Adam Sjøgren
  2011-02-13 19:23   ` Lars Ingebrigtsen
  2011-02-13 19:30   ` [PATCH] " Tassilo Horn
  0 siblings, 2 replies; 8+ messages in thread
From: Adam Sjøgren @ 2011-02-13 19:13 UTC (permalink / raw)
  To: ding

* (gnus-delay-article) Fix number of seconds per day.
---
 lisp/ChangeLog     |    4 ++++
 lisp/gnus-delay.el |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index d19efb0..dc45746 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2011-02-13  Adam Sjøgren  <asjo@koldfront.dk>
+
+	* gnus-delay.el (gnus-delay-article) Fix number of seconds per day.
+
 2011-02-13  Lars Ingebrigtsen  <larsi@gnus.org>
 
 	* gnus-art.el (gnus-article-mode-line-format): Remove the article
diff --git a/lisp/gnus-delay.el b/lisp/gnus-delay.el
index a06a510..9b5a320 100644
--- a/lisp/gnus-delay.el
+++ b/lisp/gnus-delay.el
@@ -105,7 +105,7 @@ DELAY is a string, giving the length of the time.  Possible values are:
 						  (append deadline nil))))
 	   ;; If this time has passed already, add a day.
 	   (when (< deadline (gnus-float-time))
-	     (setq deadline (+ 3600 deadline))) ;3600 secs/day
+	     (setq deadline (+ 86400 deadline))) ; 86400 secs/day
 	   ;; Convert seconds to date header.
 	   (setq deadline (message-make-date
 			   (seconds-to-time deadline))))
-- 
1.7.2.3




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Make gnus-delay-article work for HH:MM on the next day.
  2011-02-13 19:13 ` [PATCH] Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
@ 2011-02-13 19:23   ` Lars Ingebrigtsen
  2011-02-13 19:29     ` [PATCH] Improve delay prompt Adam Sjøgren
  2011-02-13 19:31     ` Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
  2011-02-13 19:30   ` [PATCH] " Tassilo Horn
  1 sibling, 2 replies; 8+ messages in thread
From: Lars Ingebrigtsen @ 2011-02-13 19:23 UTC (permalink / raw)
  To: ding

asjo@koldfront.dk (Adam Sjøgren) writes:

> * (gnus-delay-article) Fix number of seconds per day.

Applied and pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] Improve delay prompt.
  2011-02-13 19:23   ` Lars Ingebrigtsen
@ 2011-02-13 19:29     ` Adam Sjøgren
  2011-02-13 19:40       ` Lars Ingebrigtsen
  2011-02-13 19:31     ` Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
  1 sibling, 1 reply; 8+ messages in thread
From: Adam Sjøgren @ 2011-02-13 19:29 UTC (permalink / raw)
  To: ding

* gnus-delay.el (gnus-delay-article) Improve prompt.
---
 lisp/ChangeLog     |    1 +
 lisp/gnus-delay.el |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index dc45746..1a1afdf 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,6 +1,7 @@
 2011-02-13  Adam Sjøgren  <asjo@koldfront.dk>
 
 	* gnus-delay.el (gnus-delay-article) Fix number of seconds per day.
+	Improve prompt.
 
 2011-02-13  Lars Ingebrigtsen  <larsi@gnus.org>
 
diff --git a/lisp/gnus-delay.el b/lisp/gnus-delay.el
index 9b5a320..bfd1705 100644
--- a/lisp/gnus-delay.el
+++ b/lisp/gnus-delay.el
@@ -78,7 +78,7 @@ DELAY is a string, giving the length of the time.  Possible values are:
   time, then the deadline is tomorrow, else today."
   (interactive
    (list (read-string
-	  "Target date (YYYY-MM-DD) or length of delay (units in [mhdwMY]): "
+	  "Target date (YYYY-MM-DD), time (hh:mm), or length of delay (units in [mhdwMY]): "
 	  gnus-delay-default-delay)))
   (let (num unit days year month day hour minute deadline)
     (cond ((string-match
-- 
1.7.2.3





^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Make gnus-delay-article work for HH:MM on the next day.
  2011-02-13 19:13 ` [PATCH] Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
  2011-02-13 19:23   ` Lars Ingebrigtsen
@ 2011-02-13 19:30   ` Tassilo Horn
  2011-02-13 19:33     ` Adam Sjøgren
  1 sibling, 1 reply; 8+ messages in thread
From: Tassilo Horn @ 2011-02-13 19:30 UTC (permalink / raw)
  To: ding

asjo@koldfront.dk (Adam Sjøgren) writes:

Hi!

> -	     (setq deadline (+ 3600 deadline))) ;3600 secs/day
> +	     (setq deadline (+ 86400 deadline))) ; 86400 secs/day

That's pretty funny.  Kai Grossjohann added that code on 2001-08-15, and
it took us 9.5 years to find out that a day is still a bit longer. ;-)

Bye,
Tassilo
-- 
Sent from my Emacs



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Make gnus-delay-article work for HH:MM on the next day.
  2011-02-13 19:23   ` Lars Ingebrigtsen
  2011-02-13 19:29     ` [PATCH] Improve delay prompt Adam Sjøgren
@ 2011-02-13 19:31     ` Adam Sjøgren
  1 sibling, 0 replies; 8+ messages in thread
From: Adam Sjøgren @ 2011-02-13 19:31 UTC (permalink / raw)
  To: ding

On Sun, 13 Feb 2011 11:23:14 -0800, Lars wrote:

> asjo@koldfront.dk (Adam Sjøgren) writes:

>> * (gnus-delay-article) Fix number of seconds per day.

> Applied and pushed.

Thanks! Immediately after sending it, I remember that the prompt could
do with a slight update as well...


  Best regards,

    Adam

-- 
 "I went for the fireengines                                  Adam Sjøgren
  But they were all upside down"                         asjo@koldfront.dk




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Make gnus-delay-article work for HH:MM on the next day.
  2011-02-13 19:30   ` [PATCH] " Tassilo Horn
@ 2011-02-13 19:33     ` Adam Sjøgren
  0 siblings, 0 replies; 8+ messages in thread
From: Adam Sjøgren @ 2011-02-13 19:33 UTC (permalink / raw)
  To: ding

On Sun, 13 Feb 2011 20:30:05 +0100, Tassilo wrote:

> asjo@koldfront.dk (Adam Sjøgren) writes:

>> -	     (setq deadline (+ 3600 deadline))) ;3600 secs/day
>> +	     (setq deadline (+ 86400 deadline))) ; 86400 secs/day

> That's pretty funny.  Kai Grossjohann added that code on 2001-08-15, and
> it took us 9.5 years to find out that a day is still a bit longer. ;-)

Not the most widely used function in Gnus, I suppose. On the other hand,
the prompt didn't advertise the hh:mm functionality, so...


  :-),

   Adam

-- 
 "I went for the fireengines                                  Adam Sjøgren
  But they were all upside down"                         asjo@koldfront.dk




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Improve delay prompt.
  2011-02-13 19:29     ` [PATCH] Improve delay prompt Adam Sjøgren
@ 2011-02-13 19:40       ` Lars Ingebrigtsen
  0 siblings, 0 replies; 8+ messages in thread
From: Lars Ingebrigtsen @ 2011-02-13 19:40 UTC (permalink / raw)
  To: ding

asjo@koldfront.dk (Adam Sjøgren) writes:

> * gnus-delay.el (gnus-delay-article) Improve prompt.

Applied and pushed.

Don't you have commit access to Gnus yet?  Mail me the output of
"htpasswd -n asjo" and I'll add you...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-02-13 19:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-13 18:27 Delayed sending by time Adam Sjøgren
2011-02-13 19:13 ` [PATCH] Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
2011-02-13 19:23   ` Lars Ingebrigtsen
2011-02-13 19:29     ` [PATCH] Improve delay prompt Adam Sjøgren
2011-02-13 19:40       ` Lars Ingebrigtsen
2011-02-13 19:31     ` Make gnus-delay-article work for HH:MM on the next day Adam Sjøgren
2011-02-13 19:30   ` [PATCH] " Tassilo Horn
2011-02-13 19:33     ` Adam Sjøgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).