From: "Garreau\, Alexandre" <galex-713@galex-713.eu>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: ding@gnus.org
Subject: Two successive patches about the same function [Was: Re: message-simplify-subject too coupled with reply (and not extensible)]
Date: Tue, 30 Oct 2018 13:28:52 +0100 [thread overview]
Message-ID: <87k1lz8vp7.fsf_-_@portable.galex-713.eu> (raw)
In-Reply-To: <87k1m1zedm.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 28 Oct 2018 19:16:21 -0700")
On 2018-10-28 at 19:16, Eric Abrahamsen wrote:
> I'm less certain about this. It's one of those cases where probably no
> one remembers why it is the way it is, and no one wants to touch it
> because who knows how things might suddenly break. If I were you I
> would report two separate bugs, so that the first had a better chance
> of being accepted.
I’ve a question about patches: a patch mention the original version, as
long as its context, so if I end trying to submit a patch for the same
function, the second will either base on the version patched by the
first, either be based on original function before first patch, and then
won’t it have problem applying after first has been applied?
In our case, the second patch is about simplifying, improving and
factorizing `gnus-simplify-subject', and arrives after the one stripping
the “concat "Re: "”, but still having it in the version of the function
it patches.
Or maybe should I report without a patch tentative? on another hand,
with what I did it’s not that long, and I suppose at worse it’s possible
to ignore the (then incorrect (or rather outdated?)) patch…
next prev parent reply other threads:[~2018-10-30 12:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 19:23 message-simplify-subject too coupled with reply (and not extensible) Garreau, Alexandre
2018-10-29 2:16 ` Eric Abrahamsen
2018-10-29 10:49 ` Garreau, Alexandre
2018-10-29 17:17 ` Eric Abrahamsen
2018-10-30 2:47 ` Garreau, Alexandre
2018-10-30 4:57 ` `gnus-bug' bug? [Was: Re: message-simplify-subject too coupled with reply (and not extensible)] Garreau, Alexandre
2018-10-30 21:33 ` `gnus-bug' bug? [ Eric Abrahamsen
2018-11-01 4:17 ` `gnus-bug' bug? Garreau, Alexandre
2018-10-30 12:28 ` Garreau, Alexandre [this message]
2018-10-30 21:35 ` Two successive patches about the same function [ Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1lz8vp7.fsf_-_@portable.galex-713.eu \
--to=galex-713@galex-713.eu \
--cc=ding@gnus.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).