Gnus development mailing list
 help / color / mirror / Atom feed
From: Colin Walters <walters@cis.ohio-state.edu>
Subject: Gnus 5.9.0 message.el removes needed headers
Date: 22 Nov 2000 02:14:50 -0500	[thread overview]
Message-ID: <87k89w32c5.fsf@meta.verbum.org> (raw)

Hello,

On "GNU Emacs 21.0.91.1 (i686-pc-linux-gnu, X toolkit)
 of Sun 2000-11-19 on meta"

when sending mail, message.el generates the headers here on line 2515:

	;; Insert some headers.
	(message-generate-headers message-required-news-headers)

where the Message-ID, Lines, Date, etc are generated.  Then,
message.el generates these headers again on line 2538:

		;; We (re)generate the Lines header.
		(when (memq 'Lines message-required-mail-headers)
		  (message-generate-headers '(Lines)))

The comment by the second generation seems to say that only the Lines
header will be regenerated; in fact, all headers with the
'message-deletable text property are deleted, including the
Message-ID, but are not restored, because only the '(Lines) header is
passed as a header to generate the second time.

The following gross hack cures the symptoms, but I think message.el
should be fixed to not require the headers to be generated twice.

walters@meta:/usr/local/share/emacs/21.0.91/lisp/gnus$ diff -u message.el /usr/src/emacs-21.0.91/lisp/gnus/message.el
--- message.el	Mon Nov 13 05:25:16 2000
+++ /usr/src/emacs-21.0.91/lisp/gnus/message.el	Wed Nov 22 02:06:45 2000
@@ -2328,7 +2328,7 @@
 	    (message-narrow-to-headers)
 	    ;; We (re)generate the Lines header.
 	    (when (memq 'Lines message-required-mail-headers)
-	      (message-generate-headers '(Lines)))
+	      (message-generate-headers message-required-mail-headers))
 	    ;; Remove some headers.
 	    (message-remove-header message-ignored-mail-headers t)
 	    (let ((mail-parse-charset message-default-charset))



             reply	other threads:[~2000-11-22  7:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-22  7:14 Colin Walters [this message]
2000-11-22 14:18 ` ShengHuo ZHU
2000-11-22 16:02   ` Christopher Splinter
2000-11-22 16:37     ` ShengHuo ZHU
2000-11-22 16:14   ` Colin Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k89w32c5.fsf@meta.verbum.org \
    --to=walters@cis.ohio-state.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).