* [PATCH] gnus-diary: Fix gnus-completing-read call.
@ 2010-10-15 17:46 Kan-Ru Chen
2010-10-15 18:27 ` Julien Danjou
0 siblings, 1 reply; 2+ messages in thread
From: Kan-Ru Chen @ 2010-10-15 17:46 UTC (permalink / raw)
To: ding
---
Hi,
This patch fixed the gnus-completing-read call in gnus-diary, which
seems only accepts list of strings as collection*.
*emacs `completing-read' supports list, alist, obarray, hash table, or a function.
lisp/ChangeLog | 5 +++++
lisp/gnus-diary.el | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 4583953..ec8962f 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2010-10-15 Kan-Ru Chen <kanru@kanru.info>
+
+ * gnus-diary.el (gnus-diary-check-message): Fix gnus-completing-read
+ call.
+
2010-10-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
* gnus.el: Autoload gnus-html-show-images.
diff --git a/lisp/gnus-diary.el b/lisp/gnus-diary.el
index 76d469b..c2b95c7 100644
--- a/lisp/gnus-diary.el
+++ b/lisp/gnus-diary.el
@@ -368,7 +368,7 @@ If ARG (or prefix) is non-nil, force prompting for all fields."
header ": ")))
(setq value
(if (listp (nth 1 head))
- (gnus-completing-read prompt (cons '("*" nil) (nth 1 head))
+ (gnus-completing-read prompt (cons "*" (mapcar 'car (nth 1 head)))
t value
'gnus-diary-header-value-history)
(read-string prompt value
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gnus-diary: Fix gnus-completing-read call.
2010-10-15 17:46 [PATCH] gnus-diary: Fix gnus-completing-read call Kan-Ru Chen
@ 2010-10-15 18:27 ` Julien Danjou
0 siblings, 0 replies; 2+ messages in thread
From: Julien Danjou @ 2010-10-15 18:27 UTC (permalink / raw)
To: Kan-Ru Chen; +Cc: ding
On Fri, Oct 15 2010, Kan-Ru Chen wrote:
> This patch fixed the gnus-completing-read call in gnus-diary, which
> seems only accepts list of strings as collection*.
Pushed.
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-15 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-15 17:46 [PATCH] gnus-diary: Fix gnus-completing-read call Kan-Ru Chen
2010-10-15 18:27 ` Julien Danjou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).