* gnus-configure-posting-styles: Use with-silent-modifications
@ 2012-12-17 19:59 Christopher Schmidt
2012-12-25 11:43 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Schmidt @ 2012-12-17 19:59 UTC (permalink / raw)
To: ding
Right at the end of gnus-configure-posting-styles there is this form:
(when (or name address)
(add-hook 'message-setup-hook
`(lambda ()
(set (make-local-variable 'user-mail-address)
,(or (cdr address) user-mail-address))
(let ((user-full-name ,(or (cdr name) (user-full-name)))
(user-mail-address
,(or (cdr address) user-mail-address)))
(save-excursion
(message-remove-header "From")
(message-goto-eoh)
(insert "From: " (message-make-from) "\n"))))
nil 'local))
When the hook is run, the message buffer will be modified and undo
information will be stored in buffer-undo-list. That does not feel
right. I think the body forms of this save-excursion should be embedded
in a with-silent-modifications.
Christopher
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gnus-configure-posting-styles: Use with-silent-modifications
2012-12-17 19:59 gnus-configure-posting-styles: Use with-silent-modifications Christopher Schmidt
@ 2012-12-25 11:43 ` Lars Ingebrigtsen
2013-01-29 17:49 ` Christopher Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2012-12-25 11:43 UTC (permalink / raw)
To: ding
Christopher Schmidt <christopher@ch.ristopher.com> writes:
> When the hook is run, the message buffer will be modified and undo
> information will be stored in buffer-undo-list. That does not feel
> right. I think the body forms of this save-excursion should be embedded
> in a with-silent-modifications.
I think being able to undo the posting style stuff sounds like a
feature, actually...
--
(domestic pets only, the antidote for overdose, milk.)
http://lars.ingebrigtsen.no * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gnus-configure-posting-styles: Use with-silent-modifications
2012-12-25 11:43 ` Lars Ingebrigtsen
@ 2013-01-29 17:49 ` Christopher Schmidt
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Schmidt @ 2013-01-29 17:49 UTC (permalink / raw)
To: ding
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I think being able to undo the posting style stuff sounds like a
> feature, actually...
Right. I am going to work around this feature locally.
Christopher
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-29 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-17 19:59 gnus-configure-posting-styles: Use with-silent-modifications Christopher Schmidt
2012-12-25 11:43 ` Lars Ingebrigtsen
2013-01-29 17:49 ` Christopher Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).