Scrolling article with RET impossible in 5.8.4

Scrolling article with RET impossible in 5.8.4

[Raymond Scholz]

Hi!

(same for scrolling up with M-RET)

This somewhat essential function broke up in today's CVS checkins. I
guess someone with CVS access has already noticed that and can fix
it. Hope this happened _after_ the 5.8.3 release.

Cheers,
  Ray
-- 
Raymond Scholz -*- rscholz@tzi.de -*- http://www.tzi.de/~rscholz/
FB 3 Informatik, Universität Bremen -*- PGP key available via WWW

Re: Scrolling article with RET impossible in 5.8.4

[Shenghuo ZHU]

>>>>> "Raymond" == Raymond Scholz <rscholz@tzi.de> writes:

Raymond> Hi!
Raymond> (same for scrolling up with M-RET)

Raymond> This somewhat essential function broke up in today's CVS
Raymond> checkins. I guess someone with CVS access has already noticed


Raymond> that and can fix it. Hope this happened _after_ the 5.8.3
Raymond> release.

This happened after 5.8.3.

2000-01-05 17:31:52  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus-sum.el (gnus-summary-select-article): Return whether we
	selected something new.

gnus-summary-select-article should return 'old if it is old. Right?

-- 
Shenghuo

Re: Scrolling article with RET impossible in 5.8.4

[Kim-Minh Kaplan]

Shenghuo ZHU writes:

> gnus-summary-select-article should return 'old if it is old. Right?

Right.  Here is a fix.  The patch is big because of indentation
changes.

Kim-Minh.

diff -u -r5.95 gnus-sum.el
--- gnus-sum.el	2000/01/05 17:38:42	5.95
+++ gnus-sum.el	2000/01/05 22:54:07
@@ -5796,38 +5796,34 @@
     (set-buffer gnus-summary-buffer))
   (let ((article (or article (gnus-summary-article-number)))
 	(all-headers (not (not all-headers))) ;Must be T or NIL.
-	gnus-summary-display-article-function
-	did)
+	gnus-summary-display-article-function)
     (and (not pseudo)
 	 (gnus-summary-article-pseudo-p article)
 	 (error "This is a pseudo-article"))
-    (prog1
-	(save-excursion
-	  (set-buffer gnus-summary-buffer)
-	  (if (or (and gnus-single-article-buffer
-		       (or (null gnus-current-article)
-			   (null gnus-article-current)
-			   (null (get-buffer gnus-article-buffer))
-			   (not (eq article (cdr gnus-article-current)))
-			   (not (equal (car gnus-article-current)
-				       gnus-newsgroup-name))))
-		  (and (not gnus-single-article-buffer)
-		       (or (null gnus-current-article)
-			   (not (eq gnus-current-article article))))
-		  force)
-	      ;; The requested article is different from the current article.
-	      (prog1
-		  (gnus-summary-display-article article all-headers)
-		(setq did article)
-		(when (or all-headers gnus-show-all-headers)
-		  (gnus-article-show-all-headers)))
+    (save-excursion
+      (set-buffer gnus-summary-buffer)
+      (if (or (and gnus-single-article-buffer
+		   (or (null gnus-current-article)
+		       (null gnus-article-current)
+		       (null (get-buffer gnus-article-buffer))
+		       (not (eq article (cdr gnus-article-current)))
+		       (not (equal (car gnus-article-current)
+				   gnus-newsgroup-name))))
+	      (and (not gnus-single-article-buffer)
+		   (or (null gnus-current-article)
+		       (not (eq gnus-current-article article))))
+	      force)
+	  ;; The requested article is different from the current article.
+	  (progn
+	    (gnus-summary-display-article article all-headers)
 	    (when (or all-headers gnus-show-all-headers)
 	      (gnus-article-show-all-headers))
-	    'old))
-      (when did
-	(gnus-article-set-window-start
-	 (cdr (assq article gnus-newsgroup-bookmarks)))))
-    did))
+	    (gnus-article-set-window-start
+	     (cdr (assq article gnus-newsgroup-bookmarks)))
+	    article)
+	(when (or all-headers gnus-show-all-headers)
+	  (gnus-article-show-all-headers))
+	'old))))
 
 (defun gnus-summary-set-current-mark (&optional current-mark)
   "Obsolete function."

Re: Scrolling article with RET impossible in 5.8.4

[Shenghuo ZHU]

>>>>> "Kim-Minh" == Kim-Minh Kaplan <kmkaplan@vocatex.fr> writes:

Kim-Minh> Shenghuo ZHU writes:
>> gnus-summary-select-article should return 'old if it is old. Right?

Kim-Minh> Right.  Here is a fix.  The patch is big because of
Kim-Minh> indentation changes.

[...]

Applied. 

-- 
Shenghuo