emacs22 fails opening nntp: Symbol's function definition is void: process-type

emacs22 fails opening nntp: Symbol's function definition is void: process-type

[Steinar Bang]

Platform:
 Ubuntu NE 10.10,
 emacs22 22.2-0ubuntu9
 git gnus

Recent gnusen fail opening all nntp servers on emacs22
Opening nntp servers fail with the error:
 Symbol's function definition is void: process-type

Here's the full error message from *Messages*
Warning: Unable to open server nntp+dough.gmane.org due to: Symbol's function definition is void: process-type; Unable to open server nntp+news.eclipse.org due to: Symbol's function definition is void: process-type; Unable to open server nntp+news.opera.com due to: Symbol's function definition is void: process-type; Unable to open server nntp+news.gmane.org due to: Symbol's function definition is void: process-type; Unable to open server nntp+news due to: Symbol's function definition is void: process-type
Mark set


I did git bisect between
ORIG_HEAD: 444ee1f3a74bad82440f49a73e3140a0cf247e23
HEAD: bd74ba3e89556c0194b3ab3051226d3d8cb16cf0

Full rebuild with
 (cd ~/git/gnus; make clean; make; cd lisp; make tags)
and start of gnus in a fresh emacs after each git bisect good/bad.

And git bisect points the finger at the following commit, which from its
description, doesn't sound related at all:

sb@aa1steinar:~/git/gnus$ git bisect good
387b3ba7d4c42771d541085cddfc02ebf276521d is the first bad commit
commit 387b3ba7d4c42771d541085cddfc02ebf276521d
Author: Katsumi Yamaoka <yamaoka@jpl.org>
Date:   Tue May 10 03:10:49 2011 +0000

    shr.el (shr-put-image-function): New variable.
     (shr-image-fetched, shr-image-displayer, shr-tag-img): Funcall it.
     (shr-put-image): Return scaled image.
    gnus-art.el (gnus-shr-put-image): New function.
     (gnus-article-prepare-display): Bind shr-put-image-function to it.
    gnus-html.el (gnus-html-wash-images): Register scaled images, not original ones, as deletable.

:040000 040000 35f683e944f546382650c488218e8c895ae6cd5a 9fa356164b9f438eb9bbdbb5ee831098230889ef M	lisp

Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

Steinar Bang wrote:
> Platform:
>  Ubuntu NE 10.10,
>  emacs22 22.2-0ubuntu9
>  git gnus

> Recent gnusen fail opening all nntp servers on emacs22
> Opening nntp servers fail with the error:
>  Symbol's function definition is void: process-type

Currently I don't have Emacs 22 (in the office), but a workaround
(or a lasting solution?) seems to be:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 259 bytes --]

--- nntp.el~	2011-05-09 22:22:01.078125000 +0000
+++ nntp.el	2011-05-15 22:54:46.005653400 +0000
@@ -1365,2 +1365,3 @@
       (when (and (fboundp 'set-network-process-option)
+		 (fboundp 'process-type)
                  (eq (process-type process) 'network))

Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type

[Steinar Bang]

>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:

> Currently I don't have Emacs 22 (in the office), but a workaround
> (or a lasting solution?) seems to be:

> --- nntp.el~	2011-05-09 22:22:01.078125000 +0000
> +++ nntp.el	2011-05-15 22:54:46.005653400 +0000
> @@ -1365,2 +1365,3 @@
>        (when (and (fboundp 'set-network-process-option)
> +		 (fboundp 'process-type)
>                   (eq (process-type process) 'network))

I can verify that this patch works on emacs22.
(in fact I'm posting from gnus HEAD with this patch applied, right
now...:-) )

Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type

[Katsumi Yamaoka]

Steinar Bang wrote:
>>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:

>> Currently I don't have Emacs 22 (in the office), but a workaround
>> (or a lasting solution?) seems to be:

>> --- nntp.el~	2011-05-09 22:22:01.078125000 +0000
>> +++ nntp.el	2011-05-15 22:54:46.005653400 +0000
>> @@ -1365,2 +1365,3 @@
>>        (when (and (fboundp 'set-network-process-option)
>> +		 (fboundp 'process-type)
>>                   (eq (process-type process) 'network))

> I can verify that this patch works on emacs22.
> (in fact I'm posting from gnus HEAD with this patch applied, right
> now...:-) )

Ok.  I'll install it after verifying with all Emacsen that Gnus
supports, later.

Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type

[David Engster]

Katsumi Yamaoka writes:
> Steinar Bang wrote:
>>>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:
>
>>> Currently I don't have Emacs 22 (in the office), but a workaround
>>> (or a lasting solution?) seems to be:
>
>>> --- nntp.el~	2011-05-09 22:22:01.078125000 +0000
>>> +++ nntp.el	2011-05-15 22:54:46.005653400 +0000
>>> @@ -1365,2 +1365,3 @@
>>>        (when (and (fboundp 'set-network-process-option)
>>> +		 (fboundp 'process-type)
>>>                   (eq (process-type process) 'network))
>
>> I can verify that this patch works on emacs22.
>> (in fact I'm posting from gnus HEAD with this patch applied, right
>> now...:-) )
>
> Ok.  I'll install it after verifying with all Emacsen that Gnus
> supports, later.

So the buildbot was right after all... The patch should be fine for all
Emacsen. Could you please also remove the bogus process-type definition
for Emacs22 from lpath.el:

index 70e3bc5..2317d78 100644
--- a/lisp/lpath.el
+++ b/lisp/lpath.el
@@ -35,7 +35,7 @@
        epg-check-configuration find-coding-system frame-device gnutls-negotiate
        libxml-parse-html-region recenter-top-bottom rmail-swap-buffers-maybe
        shr-insert-document w3-do-setup w3-parse-buffer w3-prepare-buffer
-       w3-region w3m-detect-meta-charset w3m-region process-type))
+       w3-region w3m-detect-meta-charset w3m-region))
     (maybe-bind
      '(epa-file-encrypt-to w3m-link-map))))


Thanks,
David

Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type

[Katsumi Yamaoka]

David Engster <deng@randomsample.de> wrote:
> Could you please also remove the bogus process-type definition
> for Emacs22 from lpath.el:
[...]

Done.

Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type

[Steinar Bang]

>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:

> David Engster <deng@randomsample.de> wrote:
>> Could you please also remove the bogus process-type definition
>> for Emacs22 from lpath.el:
> [...]

> Done.

I can verify that emacs22 works fine on the current gnus git master
branch HEAD, without the patch, I tried out earlier in the thread.