Re: View docx/doc documents from Gnus in Docview

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Andrew Cohen <acohen@ust.hk> writes:

>>>>>> "EA" == Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>     EA> The version of `doc-view-set-doc-type` in master looks almost
>     EA> exactly like what you've posted here, with the exception of the
>     EA> let* for (buffer-file-name (or buffer-file-name (buffer-name
>     EA> (current-buffer)))) at the top. Could someone have fixed it in
>     EA> the meantime?
>
> No, that small change is exactly the fix!

Oh! Ha.

> When viewing a mime part in gnus, the buffer holding the document
> doesn't have an underlying file so 'buffer-file-name is nil (unlike when
> invoking doc-view from dired). Thus the whole first part of the routine
> is skipped, and only the first few bytes are looked at to determine the
> file type (which just decides it is a zip file, and ends up with 'epub).
>
> The change I made relies on the fact that the buffer that holds the
> content for doc-view gets a name from the "filename" attribute of the
> mime part in the message (i.e. the buffer gets named something like
> "*mm* junk.docx") and this can be used to infer the file extension. Then
> things work just like they would if doc-view had been invoked for a
> buffer holding an actual file.
>
> After some thought I believe that this is worth pushing to master, which
> I'll try to do when I get some time.

Cool, thank you. I can help push if you're not able to get to it.