Gnus development mailing list
 help / color / mirror / Atom feed
* [Wang Diancheng] patch for Gnus, fix goto article failed when nnml-use-compressed-files is t
@ 2010-12-27 14:02 Wang Diancheng
  2011-01-19 22:07 ` Ted Zlatanov
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Diancheng @ 2010-12-27 14:02 UTC (permalink / raw)
  To: ding

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]


Hi,

Could someone review and process my patch, this is my first patch for
Gnus.  thank you very much.

I am really appreciated your response.


[-- Attachment #2: Type: message/rfc822, Size: 1725 bytes --]

[-- Attachment #2.1.1.1: Type: text/plain, Size: 389 bytes --]


Hi, 

Gnus backend is nnml with "(setq nnml-use-compressed-files t)"

when calling function:

(gnus-summary-goto-article
         "<201012201809341712361@163.com>")

here, "<201012201809341712361@163.com>" is a message-id of a exist
article, which is compressed by nnml.

will print error message:

Couldn't fetch article <201012201809341712361@163.com>


the attached patch for fix it.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.1.2: fix-goto-article.patch --]
[-- Type: text/x-diff, Size: 588 bytes --]

--- nnml.el~	2010-12-21 17:33:07.000000000 +0800
+++ nnml.el	2010-12-21 17:33:09.000000000 +0800
@@ -235,7 +235,11 @@
 			  (nnheader-article-to-file-alist
 			   (setq gpath (nnml-group-pathname (car group-num)
 							    nil server))))))
-	  (setq path (concat gpath (int-to-string (cdr group-num)))))
+	  (nnml-update-file-alist)
+	  (setq path (concat gpath  (if nnml-use-compressed-files
+					(cdr (assq (cdr group-num)
+						   nnml-article-file-alist))
+				      (number-to-string (cdr group-num))))))
       (setq path (nnml-article-to-file id)))
     (cond
      ((not path)

[-- Attachment #2.1.2: Type: text/plain, Size: 35 bytes --]



-- 
Best Regards,
Wang Diancheng

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Wang Diancheng] patch for Gnus, fix goto article failed when nnml-use-compressed-files is t
  2010-12-27 14:02 [Wang Diancheng] patch for Gnus, fix goto article failed when nnml-use-compressed-files is t Wang Diancheng
@ 2011-01-19 22:07 ` Ted Zlatanov
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Zlatanov @ 2011-01-19 22:07 UTC (permalink / raw)
  To: ding; +Cc: Wang Diancheng

On Mon, 27 Dec 2010 22:02:56 +0800 Wang Diancheng <dcwang@kingbase.com.cn> wrote: 

WD> Could someone review and process my patch, this is my first patch for
WD> Gnus.  thank you very much.

I didn't see a response, but this looks committed by Lars.  Thank you
for your contribution.

Ted




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-01-19 22:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-27 14:02 [Wang Diancheng] patch for Gnus, fix goto article failed when nnml-use-compressed-files is t Wang Diancheng
2011-01-19 22:07 ` Ted Zlatanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).