From: Matt Armstrong <matt@lickey.com>
Subject: Topic parameters are broken.
Date: Sat, 04 May 2002 21:15:37 -0600 [thread overview]
Message-ID: <87u1pnwahy.fsf@squeaker.lickey.com> (raw)
I've been working on a patch to gnus that introduces a new group
parameter. In testing, I found that topic parameters are broken.
Per Abrahamsen made the following change to gnus-group-find-parameter
back in October to help make "mail-followup-to" generation faster.
(this is in revision 6.60 of gnus.el).
The original version always called the
gnus-group-get-parameter-function function, which in topic mode grabs
the topic mode parameters and concatenates them together before
searching for the group parameter value.
The new version skips this, so topic parameters will always be ignored
when using gnus-group-find-parameter to look for a specific parameter.
Should this change be backed out?
(defun gnus-group-find-parameter (group &optional symbol allow-list)
"Return the group parameters for GROUP.
-If SYMBOL, return the value of that symbol in the group parameters."
+If SYMBOL, return the value of that symbol in the group parameters.
+
+If you call this function inside a loop, consider using the faster
+`gnus-group-fast-parameter' instead."
(save-excursion
(set-buffer gnus-group-buffer)
- (let ((parameters
- (nconc
- (copy-sequence
- (funcall gnus-group-get-parameter-function group))
- (gnus-parameters-get-parameter group))))
- (if symbol
- (gnus-group-parameter-value parameters symbol allow-list)
+ (if symbol
+ (gnus-group-fast-parameter group symbol allow-list)
+ (let ((parameters
+ (nconc
+ (copy-sequence
+ (funcall gnus-group-get-parameter-function group))
+ (gnus-parameters-get-parameter group))))
parameters))))
--
Don't send mail to Jesse.Holm@hole.lickey.com
The address is there for spammers to harvest.
next reply other threads:[~2002-05-05 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-05 3:15 Matt Armstrong [this message]
2002-05-05 10:02 ` Simon Josefsson
2002-05-05 12:38 ` Matt Armstrong
2002-05-05 13:08 ` Matt Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u1pnwahy.fsf@squeaker.lickey.com \
--to=matt@lickey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).