Re: Any juicy outstanding Gnus bugs?

[Nils Ackermann <nils-gmane@ackermath.info>]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Nils Ackermann <nils-gmane@ackermath.info> writes:
>
>>> Digging a bit deeper here, it seemed like it was fetching the expiry
>>> target of the wrong group.  This may now be fixed.
>>
>> Nope, sorry.
>
> Could you edebug through `nndraft-request-expire-articles' and see what
> happens? 

First a typo:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 588 bytes --]

diff --git a/lisp/nndraft.el b/lisp/nndraft.el
index 5dc51f3..97ad2b9 100644
--- a/lisp/nndraft.el
+++ b/lisp/nndraft.el
@@ -224,7 +224,7 @@ are generated if and only if they are also in `message-draft-headers'.")
   (let* ((nnmh-allow-delete-final t)
         (nnmail-expiry-target
          (or (gnus-group-find-parameter
-              (gnus-group-prefixed-name "nndraft" (list 'nndraft server))
+              (gnus-group-prefixed-name "drafts" (list 'nndraft server))
               'expiry-target t)
              nnmail-expiry-target))
         (res (nnoo-parent-function 'nndraft

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]


This fixes my setup, hooray!  The override of nnmail-expiry-target
finally works in the draft group.

I wonder though if it wouldn't be better to change this to 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: Type: text/x-diff, Size: 808 bytes --]

diff --git a/lisp/nndraft.el b/lisp/nndraft.el
index 5dc51f3..5ad4ed0 100644
--- a/lisp/nndraft.el
+++ b/lisp/nndraft.el
@@ -222,11 +222,7 @@ are generated if and only if they are also in `message-draft-hea
 (deffoo nndraft-request-expire-articles (articles group &optional server force)
   (nndraft-possibly-change-group group)
   (let* ((nnmh-allow-delete-final t)
-        (nnmail-expiry-target
-         (or (gnus-group-find-parameter
-              (gnus-group-prefixed-name "nndraft" (list 'nndraft server))
-              'expiry-target t)
-             nnmail-expiry-target))
+        (nnmail-expiry-target 'delete)
         (res (nnoo-parent-function 'nndraft
                                    'nnmh-request-expire-articles
                                    (list articles group server force)))

[-- Attachment #5: Type: text/plain, Size: 506 bytes --]


If one expires from the drafts group to some other real email folder the
aforementioned dreaded

,----
| --text follows this line--
`----

appears in *saved* articles.  Wouldn't it be best to ensure that under
no circumstances articles are expired to a mail folder from the drafts
group?  Using expiry from the drafts group to archive sent emails makes
no sense anyway since expiry only happens if the composed email is saved
at least once during composition.

Thanks for looking into this!

Cheers,
Nils