Re: Attachments broken since some time

[Tassilo Horn <tsdh@gnu.org>]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Fri, 15 May 2020 11:50:14 +0200, Tassilo Horn <tsdh@gnu.org> said:
>
>     Tassilo> Ah, now I have it!  Some time back I added
>
>     Tassilo>   (nnimap-fetch-partial-articles "text/")
>
>     Tassilo> to all my nnimap select methods.  I've thought that would do what is
>     Tassilo> documented but also fetch those missing parts as soon as I actually read
>     Tassilo> such a mail.  Seems that's not the case. :-)
>
>     Tassilo> I think that's a bit unfortunate.  If at least the button would have
>     Tassilo> some indicator (undownloaded) or something alike...
>
> ‘A C’
>      If ‘<backend>-fetch-partial-articles’ is non-‘nil’, Gnus will fetch
>      partial articles, if the backend it fetches them from supports it.
>      Currently only ‘nnimap’ does.  If you’re looking at a partial
>      article, and want to see the complete article instead, then the ‘A
>      C’ command (‘gnus-summary-show-complete-article’) will do so.
>
> although it would be nice if there was a visual indication.

The below does the job for me.  The button then reads

  [2. image/png (undownloaded, A C to fetch.)]

and the help-echo also mentions the A C command.

--8<---------------cut here---------------start------------->8---
modified   lisp/gnus/gnus-art.el
@@ -5833,6 +5833,7 @@ gnus-insert-mime-button
 	     "" "..."))
 	(gnus-tmp-length (with-current-buffer (mm-handle-buffer handle)
 			   (buffer-size)))
+        (help-echo "mouse-2: toggle the MIME part; down-mouse-3: more options")
 	gnus-tmp-type-long b e)
     (when (string-match ".*/" gnus-tmp-name)
       (setq gnus-tmp-name (replace-match "" t t gnus-tmp-name)))
@@ -5841,6 +5842,16 @@ gnus-insert-mime-button
 					  (concat "; " gnus-tmp-name))))
     (unless (equal gnus-tmp-description "")
       (setq gnus-tmp-type-long (concat " --- " gnus-tmp-type-long)))
+    (when (= 0 gnus-tmp-length)
+      (setq gnus-tmp-type-long
+            (concat
+             gnus-tmp-type-long
+             (substitute-command-keys
+              (concat "\\<gnus-summary-mode-map> (undownloaded, "
+                      "\\[gnus-summary-show-complete-article] to fetch.)"))))
+      (setq help-echo
+            (concat "Type \\[gnus-summary-show-complete-article] "
+                    "to download complete article. " help-echo)))
     (setq b (point))
     (gnus-eval-format
      gnus-mime-button-line-format gnus-mime-button-line-format-alist
@@ -5859,8 +5870,7 @@ gnus-insert-mime-button
      'keymap gnus-mime-button-map
      'face gnus-article-button-face
      'follow-link t
-     'help-echo
-     "mouse-2: toggle the MIME part; down-mouse-3: more options")))
+     'help-echo help-echo)))
 
 (defvar gnus-displaying-mime nil)
--8<---------------cut here---------------end--------------->8---

Any objections to pushing that change?  Honestly, I didn't find a way to
distinguish between "intentionally not downloaded" and "broken zero-byte
attachment", so A C with a mail with the latter will result in the same
button again, I guess.

Bye,
Tassilo