A variable to expose or not system-configuration (patch)

A variable to expose or not system-configuration (patch)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 184 bytes --]

I think, it might be handy. At least, I know some people, that would
like it. Maybe, system exposing is good, but sometimes it's ugly, and
some people just don't like it.

---Vas

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnus-msg.patch --]
[-- Type: text/x-patch, Size: 1369 bytes --]

Index: gnus-msg.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-msg.el,v
retrieving revision 6.118
diff -u -u -r6.118 gnus-msg.el
--- gnus-msg.el	1 Feb 2003 16:40:51 -0000	6.118
+++ gnus-msg.el	6 Feb 2003 08:01:21 -0000
@@ -283,6 +283,11 @@
   :group 'gnus-message
   :type 'boolean)
 
+(defcustom gnus-version-expose-system t
+  "If non-nil, `system-configuration' is exposed in `gnus-extended-version'."
+  :group 'gnus-message
+  :type 'boolean)
+
 ;;; Internal variables.
 
 (defvar gnus-inhibit-posting-styles nil
@@ -1028,7 +1033,9 @@
    (cond
     ((string-match "^\\(\\([.0-9]+\\)*\\)\\.[0-9]+$" emacs-version)
      (concat "Emacs/" (match-string 1 emacs-version)
-	     " (" system-configuration ")"))
+	     (if gnus-version-expose-system
+		 " (" system-configuration ")"
+	       "")))
     ((string-match "\\([A-Z]*[Mm][Aa][Cc][Ss]\\)[^(]*\\(\\((beta.*)\\|'\\)\\)?"
 		   emacs-version)
      (concat (match-string 1 emacs-version)
@@ -1037,8 +1044,10 @@
 		 (match-string 3 emacs-version)
 	       "")
 	     (if (boundp 'xemacs-codename)
+	     (if gnus-version-expose-system
 		 (concat " (" xemacs-codename ", " system-configuration ")")
-	       "")))
+	       (concat " (" xemacs-codename ")"))
+	     "")))
     (t emacs-version))))
 
 \f

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: A variable to expose or not system-configuration (patch)

[Lars Magne Ingebrigtsen]

deskpot@myrealbox.com (Vasily Korytov) writes:

> I think, it might be handy. At least, I know some people, that would
> like it. Maybe, system exposing is good, but sometimes it's ugly, and
> some people just don't like it.

Thanks for the patch; I've applied it to Oort Gnus v0.15 (i. e., CVS).

Could you send a patch for gnus.texi as well to document this
variable? 

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: A variable to expose or not system-configuration (patch)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 154 bytes --]

>>>>> "LMI" == Lars Magne Ingebrigtsen writes:

 LMI> Could you send a patch for gnus.texi as well to document this
 LMI> variable? 

Here it goes.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnus.texi.patch --]
[-- Type: text/x-patch, Size: 857 bytes --]

Index: gnus.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/gnus.texi,v
retrieving revision 6.414
diff -u -r6.414 gnus.texi
--- gnus.texi	30 Jan 2003 01:32:26 -0000	6.414
+++ gnus.texi	7 Feb 2003 14:05:29 -0000
@@ -11154,6 +11154,14 @@
 lists will work most of the time.  Posting to these groups (@kbd{a}) is
 still a pain, though.
 
+@item gnus-version-expose-system
+@vindex gnus-version-expose-system
+
+Your system type (@code{system-configuration} variable, such as
+@samp{i686-pc-linux}) is exposed in the auto-generated by default
+User-Agent header. Sometimes, it may be desireable (mostly because of
+aesthetic reasons) to turn it off. In this case, set it to @code{nil}.
+
 @end table
 
 You may want to do spell-checking on messages that you send out.  Or, if

[-- Attachment #1.3: Type: text/plain, Size: 141 bytes --]

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: A variable to expose or not system-configuration (patch)

[Lars Magne Ingebrigtsen]

deskpot@myrealbox.com (Vasily Korytov) writes:

> Here it goes.

Thanks for the patch; I've applied it to Oort Gnus v0.15 (i. e., CVS).

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: A variable to expose or not system-configuration (patch)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 353 bytes --]

>>>>> "VK" == Vasily Korytov writes:

>>>>> "LMI" == Lars Magne Ingebrigtsen writes:
 LMI> Could you send a patch for gnus.texi as well to document this
 LMI> variable? 

 VK> Here it goes.

Sorry, this one may have a misreading (there're two variables mentioned,
so it's not clear, which is `it'). I would suggest to use this patch
instead:

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnus.texi.patch --]
[-- Type: text/x-patch, Size: 890 bytes --]

Index: gnus.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/gnus.texi,v
retrieving revision 6.414
diff -u -r6.414 gnus.texi
--- gnus.texi	30 Jan 2003 01:32:26 -0000	6.414
+++ gnus.texi	7 Feb 2003 14:13:10 -0000
@@ -11154,6 +11154,15 @@
 lists will work most of the time.  Posting to these groups (@kbd{a}) is
 still a pain, though.
 
+@item gnus-version-expose-system
+@vindex gnus-version-expose-system
+
+Your system type (@code{system-configuration} variable, such as
+@samp{i686-pc-linux}) is exposed in the auto-generated by default
+User-Agent header. Sometimes, it may be desireable (mostly because of
+aesthetic reasons) to turn it off. In this case, set
+@code{gnus-version-expose-system} to @code{nil}.
+
 @end table
 
 You may want to do spell-checking on messages that you send out.  Or, if

[-- Attachment #1.3: Type: text/plain, Size: 141 bytes --]

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: A variable to expose or not system-configuration (patch)

[Lars Magne Ingebrigtsen]

deskpot@myrealbox.com (Vasily Korytov) writes:

> Sorry, this one may have a misreading (there're two variables mentioned,
> so it's not clear, which is `it'). I would suggest to use this patch
> instead:

Could you send me a new patch against current cvs?  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: A variable to expose or not system-configuration (patch)

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

>>>>> "LMI" == Lars Magne Ingebrigtsen writes:

 LMI> deskpot@myrealbox.com (Vasily Korytov) writes:
 >> Sorry, this one may have a misreading (there're two variables mentioned,
 >> so it's not clear, which is `it'). I would suggest to use this patch
 >> instead:

 LMI> Could you send me a new patch against current cvs?  :-)

Sure. =)) But:

1. I've looked at the first and the second version with a fresh eye (I'm
   just awaken) and I think, the second version isn't really needed.
   (And I know of no other opinions on this subject.)

2. If we change the default, the texinfo should be as well corrected.

So, probably, it's worth waiting a bit (and reading this list) before
doing so.

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]