er...gpg.el text..?

er...gpg.el text..?

[Josh Huber]

I just updated yesterday (I think), and the outpt text from signature
verification is no longer displayed in the article buffer.

Anyone else seeing this?  There is still a slight delay leading me to
believe that the checking is still going on, but the output from the
check is not there...

Thanks,

-- 
Josh Huber

Re: er...gpg.el text..?

[Vincent Bernat]

OoO En ce début de soirée du lundi 27 août 2001, vers 21:12, Josh
Huber disait:

> I just updated yesterday (I think), and the outpt text from signature
> verification is no longer displayed in the article buffer.

Same problem here.
-- 
 > Voici mon problème, j'ai deux PCs relies par des cartes ethernet, 
 > configures avec le protocole PPP.
 -+- Romain in Guide du linuxien pervers - "Ils sont fous ces romains !" -+-

Re: er...gpg.el text..?

[Simon Josefsson]

Josh Huber <huber@alum.wpi.edu> writes:

> I just updated yesterday (I think), and the outpt text from signature
> verification is no longer displayed in the article buffer.

Perhaps this is a feature, `gnus-unbuttonized-mime-types' says which
MIME parts should not have buttons, and the default is .*/.*.

But the default behaviour is perhaps not ideal, it should be possibly
to override `gnus-unbuttonized-mime-types' and possibly
multipart/signed should be buttonized by default.

OTOH the buttons look ugly and interfere with reading of the article
so maybe they really should be unbuttonized by default.  Using the
Emacs 21 fringe to indicate which part of the mail is signed would
actually be good, but I dunno about XEmacs.

What do you think about this patch?

--- gnus-art.el.~6.106.~	Mon Aug 20 20:06:14 2001
+++ gnus-art.el	Wed Sep  5 20:52:18 2001
@@ -672,7 +672,15 @@
   :type '(repeat regexp))
 
 (defcustom gnus-unbuttonized-mime-types '(".*/.*")
-  "List of MIME types that should not be given buttons when rendered inline."
+  "List of MIME types that should not be given buttons when rendered inline.
+See also `gnus-buttonized-mime-types' which may override this variable."
+  :version "21.1"
+  :group 'gnus-article-mime
+  :type '(repeat regexp))
+
+(defcustom gnus-buttonized-mime-types '("multipart/signed")
+  "List of MIME types that should be given buttons when rendered inline.
+This variable overrides `gnus-unbuttonized-mime-types'."
   :version "21.1"
   :group 'gnus-article-mime
   :type '(repeat regexp))
@@ -3934,11 +3942,16 @@
 (defun gnus-unbuttonized-mime-type-p (type)
   "Say whether TYPE is to be unbuttonized."
   (unless gnus-inhibit-mime-unbuttonizing
-    (catch 'found
+    (when (catch 'found
       (let ((types gnus-unbuttonized-mime-types))
 	(while types
 	  (when (string-match (pop types) type)
-	    (throw 'found t)))))))
+		  (throw 'found t)))))
+      (not (catch 'found
+	     (let ((types gnus-buttonized-mime-types))
+	       (while types
+		 (when (string-match (pop types) type)
+		   (throw 'found t)))))))))
 
 (defun gnus-article-insert-newline ()
   "Insert a newline, but mark it as undeletable."

Re: er...gpg.el text..?

[Kai Großjohann]

Simon Josefsson <jas@extundo.com> writes:

> Perhaps this is a feature, `gnus-unbuttonized-mime-types' says which
> MIME parts should not have buttons, and the default is .*/.*.

Is there a reason not to use "/", or even "", as the default for this
variable?

There is another variable which is "text/.*" I think -- couldn't that
be just "text/"?

kai
-- 
Symbol's function definition is void: signature

Re: er...gpg.el text..?

[Josh Huber]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Is there a reason not to use "/", or even "", as the default for
> this variable?
>
> There is another variable which is "text/.*" I think -- couldn't
> that be just "text/"?

Ah, finally...

this must have been changed?  Doesn't it make sense to only hide text/
parts?

I use:

(setq gnus-unbuttonized-mime-types '("text/"))

now, and it works the way I'd expect it to work by default... I would
think...

thanks a lot :)

-- 
Josh Huber

Re: er...gpg.el text..?

[Simon Josefsson]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

>> Perhaps this is a feature, `gnus-unbuttonized-mime-types' says which
>> MIME parts should not have buttons, and the default is .*/.*.
>
> Is there a reason not to use "/", or even "", as the default for this
> variable?

I think Lars doesn't like the buttons.

Re: er...gpg.el text..?

[Kai Großjohann]

Simon Josefsson <jas@extundo.com> writes:

> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
>
>>> Perhaps this is a feature, `gnus-unbuttonized-mime-types' says which
>>> MIME parts should not have buttons, and the default is .*/.*.
>>
>> Is there a reason not to use "/", or even "", as the default for this
>> variable?
>
> I think Lars doesn't like the buttons.

????

Now, the value is ".*/.*".  But the regex "/" is shorter, simpler, and
should have the same effect, no?

And since all MIME types contain a slash, "" would be even better,
since it always matches.

kai
-- 
Symbol's function definition is void: signature

Re: er...gpg.el text..?

[Simon Josefsson]

On Thu, 6 Sep 2001, Kai Großjohann wrote:

> Simon Josefsson <jas@extundo.com> writes:
>
> > Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> >
> >>> Perhaps this is a feature, `gnus-unbuttonized-mime-types' says which
> >>> MIME parts should not have buttons, and the default is .*/.*.
> >>
> >> Is there a reason not to use "/", or even "", as the default for this
> >> variable?
> >
> > I think Lars doesn't like the buttons.
>
> ????

Sorry, I misinterpreted, thought you wanted to buttonize everything by
default.

> Now, the value is ".*/.*".  But the regex "/" is shorter, simpler, and
> should have the same effect, no?
>
> And since all MIME types contain a slash, "" would be even better,
> since it always matches.

Yes, but maybe it is less intuitive.   Since the behaviour stays the same,
why change?  `.*/.*' as a default for MIME types feel pretty intuitive to
me, if I saw only `/' I would think it would only match ^/$ but since
string-match is used, this doesn't happen... O well.