message-unique-id

message-unique-id

[Jason R. Mastaler]

The end of `message-unique-id' says:

     ;; Append the newsreader name, because while the generated
     ;; ID is unique to this newsreader, other newsreaders might
     ;; otherwise generate the same ID via another algorithm.
     ".fsf")))

Last time I checked, ``fsf'' wasn't the name of this newsreader.  
I suggest changing this string to ".gnus" to reduce the chance of
collision with other softwares.

Re: message-unique-id

[Lars Magne Ingebrigtsen]

"Jason R. Mastaler" <jason@mastaler.com> writes:

> Last time I checked, ``fsf'' wasn't the name of this newsreader.  
> I suggest changing this string to ".gnus" to reduce the chance of
> collision with other softwares.

I don't think there's much chance of other newsreaders using .fsf.
And it's one less character than ".gnus".  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: message-unique-id

[Jason R. Mastaler]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I don't think there's much chance of other newsreaders using .fsf.

But, a greater chance than .gnus.  It's much less obvious too that
.fsf is supposed to remain unique to Gnus.

> And it's one less character than ".gnus".  :-)

It's only one extra character.  Gnus' message-ids are terser than most
to begin with anyway, so you have some room.

Re: message-unique-id

[Paul Jarc]

"Jason R. Mastaler" <jason@mastaler.com> wrote:
> The end of `message-unique-id' says:
>
>      ;; Append the newsreader name, because while the generated
>      ;; ID is unique to this newsreader, other newsreaders might
>      ;; otherwise generate the same ID via another algorithm.
>      ".fsf")))
>
> Last time I checked, ``fsf'' wasn't the name of this newsreader.

The comment should be fixed, then.

It's not important that we identify the newsreader; it's important
that we identify the id-generation algorithm.  Then if other
newsreaders use the same algorithm and the safe suffix, that's ok.
And if future versions of Gnus use a different algorithm, they should
use a different suffix.  Granted, ".fsf" isn't a very intuitive
identifier of Gnus's current algorithm, but it's established enough
that a change isn't likely to help.


paul

Re: message-unique-id

[Lars Magne Ingebrigtsen]

"Jason R. Mastaler" <jason@mastaler.com> writes:

> But, a greater chance than .gnus.  It's much less obvious too that
> .fsf is supposed to remain unique to Gnus.

The reason for me choosing ".fsf" over ".gnus" was partly because I
though Four Characters Should Be Enough For Everybody, and partly as a
propaganda move on behalf of the FSF.

The former requirement has kinda gone away, but the latter is still an
issue.

I'm a sneaky guy.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: message-unique-id

[Jesper Harder]

"Jason R. Mastaler" <jason@mastaler.com> writes:

> The end of `message-unique-id' says:
>
>      ;; Append the newsreader name, because while the generated
>      ;; ID is unique to this newsreader, other newsreaders might
>      ;; otherwise generate the same ID via another algorithm.
>      ".fsf")))
>
> Last time I checked, ``fsf'' wasn't the name of this newsreader.  I
> suggest changing this string to ".gnus" to reduce the chance of
> collision with other softwares.

I think the 'message' library is intended to be usable by other clients
than Gnus.  The string "fsf" makes more sense than "gnus" in that light,
IMHO.

Re: message-unique-id

[Lars Magne Ingebrigtsen]

prj@po.cwru.edu (Paul Jarc) writes:

>>      ;; Append the newsreader name, because while the generated
>>      ;; ID is unique to this newsreader, other newsreaders might
>>      ;; otherwise generate the same ID via another algorithm.
>>      ".fsf")))
>>
>> Last time I checked, ``fsf'' wasn't the name of this newsreader.
>
> The comment should be fixed, then.

I've now done so.

I think that demonstrates the problem of writing the comments before
writing the code, because obviously I was intending to put ".gnus"
there when I started writing the comment, but had changed my mind when
I hit the code.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen